Skip to content

Chris pv stream viewer systemcore #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

gerth2
Copy link
Contributor

@gerth2 gerth2 commented Jun 30, 2025

Description

Added an ipk that shows mjpeg streams for all cameras it sees

image

very WIP closes nothing

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@gerth2
Copy link
Contributor Author

gerth2 commented Jun 30, 2025

image

@samfreund
Copy link
Member

samfreund commented Jul 4, 2025

Consider displaying each camera as a single block, and making the raw and processed streams toggleable (when both are on the block would expand). Name by hostname then camera name, and perhaps show port if user hovers?

@samfreund
Copy link
Member

Dark favicon is a better choice, since atp the SystemCore theme is also dark by default, and there doesn't seem to be a light mode.

@samfreund samfreund force-pushed the chris_pv_stream_viewer_systemcore branch from 59aeeab to 5c7aef2 Compare July 4, 2025 18:25
@samfreund
Copy link
Member

Publish the .ipk with the release.

@samfreund
Copy link
Member

image
It's showing there's no MJPEG stream found for dupe, but the two right after it are, in fact, the feed from the dupe camera

@samfreund
Copy link
Member

Consider renaming to Photon Viewer for brevity, as the current title doesn't fit within a tab. Additionally, this would exhibit consistency with what we currently title our client windows in a browser.

@samfreund samfreund force-pushed the chris_pv_stream_viewer_systemcore branch from 5c7aef2 to a735a15 Compare July 4, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants