Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big scary buttons #1471

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Big scary buttons #1471

wants to merge 9 commits into from

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Oct 15, 2024

image
image

srimanachanta
srimanachanta reviewed Oct 16, 2024
View reviewed changes
photon-client/src/components/settings/DeviceControlCard.vue Outdated
@@ -201,6 +201,39 @@ const handleSettingsImport = () => {
importType.value = -1;
importFile.value = null;
};

const showFactoryReset = ref(false);
const expected = "I solumnly swear that I am up to no good";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just inline this with the text

@crschardt
Copy link
Contributor

Are you planning to clear the journalctl logs when you delete the configuration files?

@Juniormunk
Copy link
Contributor

Juniormunk commented Oct 18, 2024 •
edited
Loading

Are you planning to clear the journalctl logs when you delete the configuration files?

I would like this as a separate feature additionally

@crschardt crschardt mentioned this pull request Oct 18, 2024
Open
@mcm001
Copy link
Contributor Author

mcm001 commented Oct 18, 2024

It might not hurt to, but I'm ok with letting the OS decide when it's time to trim logs

@crschardt
Copy link
Contributor

I believe that the default for systemd journal is 4GB of logs. We might not want to let it get that big and we could cap it in journald.conf to something more manageable.

@mcm001
Copy link
Contributor Author

mcm001 commented Oct 19, 2024

I believe that the default for systemd journal is 4GB of logs. We might not want to let it get that big and we could cap it in journald.conf to something more manageable.

Let's cap it to a couple hundred MB? 100MB maybe? that'll take forever over the radio already. But I don't think we need a UI button to do that.

@mcm001 mcm001 marked this pull request as ready for review October 19, 2024 05:27
@mcm001 mcm001 requested a review from a team as a code owner October 19, 2024 05:27
@mcm001
Copy link
Contributor Author

mcm001 commented Oct 19, 2024

image
image
image
image
1366x768 device.

bit funky with mobile tho
image
image

@crschardt crschardt mentioned this pull request Oct 19, 2024
Open
mcm001 and others added 2 commits October 19, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crschardt crschardt crschardt left review comments

@srimanachanta srimanachanta srimanachanta left review comments

@spacey-sooty spacey-sooty spacey-sooty left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcm001 @crschardt @Juniormunk @srimanachanta @spacey-sooty