Auto-generate packet dataclasses with Jinja #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
changed the title
|
PhotonSerialisationTest.xlsx |
mcm001
force-pushed
the
20240714_serde_packet_gen
branch
2 times, most recently
from
a4a896d
to
d93c6fc
Compare
mcm001
force-pushed
the
20240714_serde_packet_gen
branch
from
607db0e
to
eb40c0b
Compare
spacey-sooty
reviewed
Aug 5, 2024
|
No, that's weird |
crschardt
requested changes
Aug 17, 2024
mcm001
force-pushed
the
20240714_serde_packet_gen
branch
4 times, most recently
from
c3d3357
to
f81ea12
Compare
|
This is a big one, obviously. I've given it a once over, strategy for generation looks good, and it passes a basic smoke test in Python on my setup Per discord, we will merge this one and do the deep dive later, as part of the example rework. |
mcm001
force-pushed
the
20240714_serde_packet_gen
branch
from
4b2c302
to
bf177c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generate our packet serde code. This lets us have a schema hash instead of photon versions.