Add caching for images - #7
Merged
Merged
Conversation
mcm001
previously approved these changes
Apr 25, 2026
Member
|
Since this is part of the runner, will it cache images in the monorepo? |
Collaborator
Author
I'm pretty sure it will cache the files in the repo that calls the runner. The free cache size for our repos is 10GB, so we may need to be selective about what we cache. The other twist is that cached artifacts aren't shared between branches. All branches have access to the artifacts cached by main, so I think we'll want to make sure we seed main quickly if we decide to use this on the monorepo. |
This reverts commit 9029f80.
crschardt
marked this pull request as ready for review
May 3, 2026 18:22
mcm001
reviewed
May 3, 2026
mcm001
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables storage of downloaded images in GitHub's cache action. This should reduce the build time for new images as well as making builds more robust to problems accessing the download source.
Control of the feature is through the
use-cacheparameter which defaults to"no".This PR also makes sure that the shell script that contains commands is removed and it overwrites the commands.sh file if it exists. This prevents a problem that would cause the commands to be run a second time if an image that has been modified is re-used, as is the case when tests are run on the image in a separate step.
An implementation detail, which shouldn't alter behavior is that the root file system is now placed under the location specified by the GitHub
$RUNNER_TEMPenvironment variable.Finally, the tests have been reworked to include: