Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair: trying to refine the errors, doesn't work as expected #95

Merged
merged 6 commits into from
Aug 17, 2023

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Aug 14, 2023

No description provided.

@gangov gangov linked an issue Aug 14, 2023 that may be closed by this pull request
contracts/pair/src/error.rs Outdated Show resolved Hide resolved
gangov and others added 3 commits August 15, 2023 22:50
…lar error after I changed the assertions, probably worth looking at;

Stake: refactors the error messages
Token: fixes an issue in make lint
@ueco-jb ueco-jb marked this pull request as ready for review August 17, 2023 08:17
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you ignored those failing testcases, it's good to merge.
Those tests weren't testing properly before, I will take care of it when you merge your other PR.
Just add some comments above those ignore decorators.

contracts/pair/src/storage.rs Outdated Show resolved Hide resolved
@gangov gangov merged commit 8d4329d into main Aug 17, 2023
3 checks passed
@gangov gangov deleted the 85-refine-errors-in-contracts branch August 17, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine errors in contracts
2 participants