Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

89 stake create stake totalstaked variable in storage #94

Merged
merged 6 commits into from
Aug 14, 2023
Merged

89 stake create stake totalstaked variable in storage #94

merged 6 commits into from
Aug 14, 2023

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Aug 14, 2023

No description provided.

@gangov gangov linked an issue Aug 14, 2023 that may be closed by this pull request
Stake: Create stake TotalStaked variable in storage #89
Closed
@ueco-jb ueco-jb marked this pull request as ready for review August 14, 2023 09:55
ueco-jb
ueco-jb requested changes Aug 14, 2023
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked you to add new query and then test that new query.

#89

Add query to read that data.
Add tests to make sure that it increases/decreases with each bond/unbond

Please pay attention to the task description...

contracts/stake/src/contract.rs Outdated Show resolved Hide resolved
contracts/stake/src/storage.rs Outdated Show resolved Hide resolved
contracts/stake/src/storage.rs Outdated Show resolved Hide resolved
contracts/stake/src/tests/bond.rs Outdated Show resolved Hide resolved
contracts/stake/src/tests/bond.rs Show resolved Hide resolved
@gangov gangov self-assigned this Aug 14, 2023
ueco-jb
ueco-jb approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
My only nitpick - you could rename increase_staked to increase_total_staked for better clarity (decrease as well obviously).

@gangov gangov merged commit aed74f8 into main Aug 14, 2023
3 checks passed
@gangov gangov deleted the 89-stake-create-stake-totalstaked-variable-in-storage branch August 14, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

Assignees

@gangov gangov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stake: Create stake TotalStaked variable in storage
2 participants
@gangov @ueco-jb