Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool_stable: adds more contracterrrors #268

Merged
merged 7 commits into from
Mar 13, 2024
Merged

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Mar 13, 2024

No description provided.

@gangov gangov self-assigned this Mar 13, 2024
@gangov gangov linked an issue Mar 13, 2024 that may be closed by this pull request
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things.

contracts/pool/src/contract.rs Show resolved Hide resolved
contracts/pool/src/storage.rs Show resolved Hide resolved
@gangov
Copy link
Collaborator Author

gangov commented Mar 13, 2024

I just noticed that we are still using panic! instead of panic_with_error! throughout the contracts, does that need to be addressed

@gangov gangov requested a review from ueco-jb March 13, 2024 13:41
@ueco-jb
Copy link
Member

ueco-jb commented Mar 13, 2024

does that need to be addressed

Yes.

@gangov
Copy link
Collaborator Author

gangov commented Mar 13, 2024

does that need to be addressed

Yes.

alright, I'll do it in this PR

@gangov gangov force-pushed the 266-pool-and-pool_stable-parity branch from 4532e24 to 0b70f6d Compare March 13, 2024 16:12
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, LGTM

@ueco-jb ueco-jb merged commit a4902de into main Mar 13, 2024
3 checks passed
@ueco-jb ueco-jb deleted the 266-pool-and-pool_stable-parity branch March 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pool and pool_stable parity
2 participants