Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factory: adds new query to search for a liquidity pool address by a tuple of Pair. Tests the new functionality. #131

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Factory: adds new query to search for a liquidity pool address by a tuple of Pair. Tests the new functionality. #131

merged 3 commits into from
Sep 19, 2023

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Sep 14, 2023

No description provided.

@gangov gangov linked an issue Sep 14, 2023 that may be closed by this pull request
Factory: New queries #130
Closed
@gangov gangov self-assigned this Sep 14, 2023
ueco-jb
ueco-jb reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code and good test. I added some comments to remove some stuff, especially trim that test case.

contracts/factory/src/contract.rs Outdated Show resolved Hide resolved
contracts/factory/src/storage.rs Outdated Show resolved Hide resolved
contracts/factory/src/tests/queries.rs Outdated Show resolved Hide resolved
contracts/factory/src/tests/queries.rs Outdated Show resolved Hide resolved
@gangov gangov marked this pull request as ready for review September 18, 2023 16:14
@gangov gangov requested a review from ueco-jb September 18, 2023 16:14
ueco-jb
ueco-jb approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contracts/factory/src/tests/queries.rs Show resolved Hide resolved
@ueco-jb ueco-jb merged commit a94564b into main Sep 19, 2023
3 checks passed
@ueco-jb ueco-jb deleted the 130-factory-new-queries branch September 19, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

Assignees

@gangov gangov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Factory: New queries
2 participants
@gangov @ueco-jb