Phoenix: creates initial sceleton with a single err and a copy of pai… #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Don't use common structure for all the errors, it's not a good idea.
Don't leave commented code.
I'm still thinking if phoenix is a good name. Seems like it, given that it would become a core component for probably most of out contracts, but may be confusing.
Let's leave it as it is, just pointing that out.
|
about the name of the new library - yeah I also thought of that, as I was constantly getting confused. We probably can go with something more verbose probably phoenix_helper, but we can give it a thought later |
gangov
force-pushed
the
113-pair-move-utils-into-a-separate-library
branch
from
ec33e70
to
960297b
Compare
ueco-jb
approved these changes
Aug 31, 2023
gangov
force-pushed
the
113-pair-move-utils-into-a-separate-library
branch
from
960297b
to
e842dde
Compare
…r/utils.rs. Once implemented in full we need to pick it up from here and do some heavy refactoring
…nfo) and importing of contract clients
…and makes chnages to the pair and factory cargo.tomls
Pair: fixes imports
…re we don't store errors in the helper lib Pair: adds the helper macro validate_int_parameters Pair-stable: adds the helper macor validate_int_parameters
gangov
force-pushed
the
113-pair-move-utils-into-a-separate-library
branch
from
e86b7b4
to
da135b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r/utils.rs. Once implemented in full we need to pick it up from here and do some heavy refactoring