Memory Leaks Suspect

[admentPL]

I have been experiencing OOM exception in my app, which is using graph and pie charts, on multiple screen rotation. At first I suspected it was my fault but I have analyzed my app with DDMS heap dump and MAT tool and Leak Suspect report pointed to PieChart objects. I have then decided to check the MPAndroidChart sample app and the Leak Suspect report pointed a couple of problems. However I am not able to crash the sample app by rotating the screen (although it does not consume any other memory apart from charts which might be the cause). Can you analyze the lib with MAT and check the Leak Suspect report?

[admentPL]

PS: here is the exception from my crash. Maybe ti can help although I know it doesn't have to be the root of the problem:

java.lang.OutOfMemoryError
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.graphics.Bitmap.nativeCreate(Native Method)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.graphics.Bitmap.createBitmap(Bitmap.java:924)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.graphics.Bitmap.createBitmap(Bitmap.java:901)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.graphics.Bitmap.createBitmap(Bitmap.java:868)
10-10 11:45:18.366: E/S-EDUSDK(20646): at com.github.mikephil.charting.charts.Chart.onDraw(Chart.java:496)
10-10 11:45:18.366: E/S-EDUSDK(20646): at com.github.mikephil.charting.charts.PieChart.onDraw(PieChart.java:137)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15393)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14287)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15107)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.drawChild(ViewGroup.java:3310)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3147)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14282)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15107)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.drawChild(ViewGroup.java:3310)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3147)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14282)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15107)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.drawChild(ViewGroup.java:3310)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3147)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15396)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.support.v4.view.ViewPager.draw(ViewPager.java:1574)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14287)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15107)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.drawChild(ViewGroup.java:3310)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3147)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15396)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14287)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15107)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.drawChild(ViewGroup.java:3310)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3147)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15396)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14287)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15107)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.drawChild(ViewGroup.java:3310)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3147)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14282)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15107)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.drawChild(ViewGroup.java:3310)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3147)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15396)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14287)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15107)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.drawChild(ViewGroup.java:3310)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3147)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14282)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15107)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.drawChild(ViewGroup.java:3310)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3147)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15396)
10-10 11:45:18.366: E/S-EDUSDK(20646): at com.android.internal.widget.ActionBarOverlayLayout.draw(ActionBarOverlayLayout.java:466)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14287)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15107)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.drawChild(ViewGroup.java:3310)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3147)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.draw(View.java:15396)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.widget.FrameLayout.draw(FrameLayout.java:472)
10-10 11:45:18.366: E/S-EDUSDK(20646): at com.android.internal.policy.impl.PhoneWindow$DecorView.draw(PhoneWindow.java:2583)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14287)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.View.getDisplayList(View.java:14329)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.HardwareRenderer$GlRenderer.buildDisplayList(HardwareRenderer.java:1570)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.HardwareRenderer$GlRenderer.draw(HardwareRenderer.java:1449)
10-10 11:45:18.366: E/S-EDUSDK(20646): at android.view.ViewRootImpl.draw(ViewRootImpl.java:275

[bartosz-bilicki]

In com.github.mikephil.charting.charts.Chart.init() I see that we have static reference to android.content.res.Resources, initialized as follows Utils.init(getContext().getResources());

Checking Eclipse memory analiser log, I see
mOuterContext android.app.ContextImpl 
'- mContext android.content.res.Resources
   |- mRes class com.github.mikephil.charting.utils.Utils
   |- mResources android.app.LoadedApk
   |- mResources android.app.ContextImpl
   |- this$0 android.content.res.Resources$Theme
   |  '- referent java.lang.ref.FinalizerReference
   |     '- next java.lang.ref.FinalizerReference
   |        '- next java.lang.ref.FinalizerReference

This causes memory leak! Resources holds context, which holds Activity.

Note that Utils needs just DisplayMetrics from Resources, not whole Resources. I made that change locally, and now I have no more memory leaks pointing to com.github.mikephil.charting.utils.Utils

But, I do have

mBuffer android.graphics.Bitmap @ 0x42624100
'- mDrawBitmap com.bilickib.android.charts.PieChartView @ 0x425e4d58
'- pieChartView mine.PieChartFragment @ 0x424dbca8
'- mCurrentPrimaryItem com.bilickib.android.charts.PieChartFragmentPagerAdapter @ 0x424dbb18
'- pieChartFragmentPagerAdapter com.bilickib.android.charts.PieChartHolder @ 0x427654c0
'- pieChartHolder com.bilickib.android.charts.Activity @ 0x424df648
'- mContext android.os.PowerManager @ 0x4252f0c8
'- mPowerManager android.view.ViewRootImpl @ 0x425857f0
'- this$0 android.view.ViewRootImpl$WindowInputEventReceiver @ 0x425832d8
'- referent java.lang.ref.FinalizerReference @ 0x4256bfa8

That puzzles me, because neither me nor MPChartLiba are using PowerManager API. Any hints would be welcome.
I have performance issue with my charts (applications is slow and unresponsive).
I see PieChartView (my class, inheriting from PieChart) objects in memory even after closing my chart.

[PhilJay]

Thank you for noticing this. This really looks like a nasty leak. I will fix it in the next update!

Regards,
Phil

[PhilJay]

I just removed the static reference, let me know if anything else comes up.

[jemshit]

@PhilJay i still get same error with PieChart, library version v2.1.0

[jemshit]

@PhilJay i tried using android:largeHeap="true" in manifest. now i monitor memory usage. If i open activity with 2 pieCharts, memory usage +10MB. If i close it doesnt free. Then if i open again, it increases +10mb again, if i close and open again, it increases +10mb .....

It does not happen with lineChart, if fragment or acivity gets destroyed, memory is released.

[jemshit]

@PhilJay Problem is on mDrawBitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_4444); in PieChartRenderer.java, createBitmap gets MBs of memory(depends on pixels) and it is not released. This guy says he didn't find way to solve this with createBitmap: http://stackoverflow.com/a/8527745/3736955 . If you can find other option doing same job without using createBitmap, thats better.

From this answer from other library on github (4th answer by alexvasilkov alexvasilkov/FoldableLayout#10), "It looks like without Bitmap.recycle() GC will need 2 passes before it will release bitmap memory, but if you'll use Bitmap.recycle() GC will need only 1 pass to clear up bitmap memory." So try calling both recycle and gc :

System.gc();
mDrawBitmap.recycle();
mDrawBitmap= null;
mDrawBitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_4444);

[jemshit]

Currently i am using System.gc();System.gc(); (2 times) in my OnCreate() of activity and this does trick.

[mmarklar]

I'm seeing the same issue with LineCharts. I have 3 different LineCharts in different fragments and after about 5-6 rotations they cause an OOM exception. Calling System.gc(); twice as proposed by @jemshit does not fix it. Here is my stacktrace:

Process: net.marklar.rxctest, PID: 7454
java.lang.OutOfMemoryError: Failed to allocate a 4286964 byte allocation with 168740 free bytes and 164KB until OOM
at dalvik.system.VMRuntime.newNonMovableArray(Native Method)
at android.graphics.Bitmap.nativeCreate(Native Method)
at android.graphics.Bitmap.createBitmap(Bitmap.java:812)
at android.graphics.Bitmap.createBitmap(Bitmap.java:789)
at android.graphics.Bitmap.createBitmap(Bitmap.java:756)
at com.github.mikephil.charting.charts.Chart.onSizeChanged(Chart.java:1518)
at android.view.View.sizeChange(View.java:15786)
at android.view.View.setFrame(View.java:15751)
at android.view.View.layout(View.java:15667)
at android.view.ViewGroup.layout(ViewGroup.java:5038)
at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1076)
at android.view.View.layout(View.java:15671)
at android.view.ViewGroup.layout(ViewGroup.java:5038)
at android.support.v4.view.ViewPager.onLayout(ViewPager.java:1626)
at android.view.View.layout(View.java:15671)
at android.view.ViewGroup.layout(ViewGroup.java:5038)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1703)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1557)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1466)
at android.view.View.layout(View.java:15671)
at android.view.ViewGroup.layout(ViewGroup.java:5038)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579)
at android.widget.FrameLayout.onLayout(FrameLayout.java:514)
at android.view.View.layout(View.java:15671)
at android.view.ViewGroup.layout(ViewGroup.java:5038)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1703)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1557)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1466)
at android.view.View.layout(View.java:15671)
at android.view.ViewGroup.layout(ViewGroup.java:5038)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579)
at android.widget.FrameLayout.onLayout(FrameLayout.java:514)
at android.view.View.layout(View.java:15671)
at android.view.ViewGroup.layout(ViewGroup.java:5038)
at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2086)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1843)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1061)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:5885)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:767)
at android.view.Choreographer.doCallbacks(Choreographer.java:580)
at android.view.Choreographer.doFrame(Choreographer.java:550)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:753)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5254)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

[kristijanexads]

Same issue happens to me @jemshit , but System.gc() called twice doesn't help. Anyone have a solution on that?

[jaredsburrows]

What version?