Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data conversions for extra BrAPI data types #47

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

ctucker3
Copy link
Collaborator

Added conversions for data types that were left out of the original conversion. Converted the data types to the closest matches in Fieldbook:

"Code" - This scale class is exceptionally used to express complex traits. Code is a nominal scale that combines the expressions of the different traits composing the complex trait. For exemple a severity trait might be expressed by a 2 digit and 2 character code. The first 2 digits are the percentage of the plant covered by a fungus and the 2 characters refer to the delay in development, e.g. "75VD" means "75%" of the plant is Crop Ontology & Integrated Breeding Platform Curation Guidelines 5/6/2016 9 infected and the plant is very delayed.
"Date" - The date class is for events expressed in a time format, e.g. yyyymmddThh:mm:ssZ or dd/mm/yy
"Duration" - The Duration class is for time elapsed between two events expressed in a time format, e.g. days, hours, months
"Nominal" - Categorical scale that can take one of a limited and fixed number of categories. There is no intrinsic ordering to the categories
"Numerical" - Numerical scales express the trait with real numbers. The numerical scale defines the unit e.g. centimeter, ton per hectar, branches
"Ordinal" - Ordinal scales are scales composed of ordered categories
"Text" - A free text is used to express the trait.

Conversions are:

Code -> text
Ordinal -> categorical
Numerical -> numeric

@ctucker3
Copy link
Collaborator Author

@trife
Copy link
Member

trife commented Oct 24, 2019

The Code data type sounds similar to the current disease rating trait. It might be worth replacing the disease rating trait code with something that can be used more generally for Code data types if that is a popular format among breeders.

@ctucker3
Copy link
Collaborator Author

ctucker3 commented Oct 25, 2019

The Code data type sounds similar to the current disease rating trait. It might be worth replacing the disease rating trait code with something that can be used more generally for Code data types if that is a popular format among breeders.

Good thinking! I haven't looked too much into the disease rating trait, but I think I am following your train of thought. I think for now, we can leave that outside of this release and make that a future effort. Thoughts on that?

@ctucker3 ctucker3 merged commit 4a3e6de into PhenoApps_Hack_2019 Oct 25, 2019
@ctucker3 ctucker3 deleted the BBase-8 branch October 25, 2019 19:43
@trife
Copy link
Member

trife commented Oct 30, 2019

Yeah totally agree that it should be a future effort. Just getting the idea out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants