Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded extraneous columns in trait csv export #39

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

nickpalladino
Copy link
Collaborator

Excluded csv trait export columns that were added to the traits table from our brapi work. This keeps the format the same as it was before for csv trait trt files.

Copy link
Collaborator

@ctucker3 ctucker3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth it in the future to make an array of the excluded columns that could be used to get the column count and can be used in the if exclusion statement. Works the same, but might be easier to read.

Other than that, looks good!

@nickpalladino
Copy link
Collaborator Author

Ya, agree that would be less error prone. I can do that.

@ctucker3 ctucker3 merged commit 38e0ae3 into PhenoApps_Hack_2019 Oct 14, 2019
@ctucker3 ctucker3 deleted the FIE-64 branch October 14, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants