Modified security camera to use player light level for detection #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified camera to use player light level for detection Renamed spot_time to detection_threshold to reflect this change
niefia
changed the title
|
Hey, thanks for this. I've had a family emergency, so for the next couple weeks, I won't be able to work on Cogito as much as I used to. I'll trust all Cogito collaborators to review and approve any PRs and merges. |
Phazorknight
requested changes
Oct 9, 2024
There was a problem hiding this comment.
A few thoughts on this:
- This now seems very dependent on the Cogito Player having a lightmeter component. I personally don't use that component at all, so I'd want this to be integrated as purely optional.
- Also worth keeping in mind if we'd want the camera to be able to detect other entities (like other NPCs or enemies)
Detection method added to allow for easy removal and use of only Time for detection Dynamic Lightmeter find on body enter means that lightmeter is not just set to use player lightmeter, meaning NPC could also have attached lightmeter and this is used for detection Also added a non_player_detection_list array for non-player objects that should be detected to avoid detecting irrelevant objects
Phazorknight
approved these changes
Oct 10, 2024
|
In future I'd probably want to revisit the non_player_detection_list, and make it use the custom class names instead of just names. Other than that I'm happy to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified camera to use player light level for detection
Renamed spot_time to detection_threshold to reflect this change