Parsing fails for some files

[dereuromark]

Wanted to try it out, but

Found 99 files. Starting analysis.
 10/99 [==>-------------------------]  10%PHP Fatal error:  Uncaught TypeError: Cannot access offset of type PhpParser\Node\Expr\Variable in isset or empty in /data/work/app/vendor/phauthentic/cognitive-code-analysis/src/PhpParser/CognitiveMetricsVisitor.php:214
Stack trace:
#0 /data/work/app/vendor/phauthentic/cognitive-code-analysis/src/PhpParser/CognitiveMetricsVisitor.php(197): Phauthentic\CognitiveCodeAnalysis\PhpParser\CognitiveMetricsVisitor->trackVariable()
#1 /data/work/app/vendor/phauthentic/cognitive-code-analysis/src/PhpParser/CognitiveMetricsVisitor.php(189): Phauthentic\CognitiveCodeAnalysis\PhpParser\CognitiveMetricsVisitor->gatherMetrics()
#2 /data/work/app/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(114): Phauthentic\CognitiveCodeAnalysis\PhpParser\CognitiveMetricsVisitor->enterNode()

also, I had to use

vendor/bin/phpcca analyse src/Controller/

as bin/phpcca isnt available via composer require directly

[floriankraemer]

Hmm, I've tried it with three different projects at work. Is there any chance you can provide me some code that makes the parser fail, so that I can reproduce it?

[dereuromark]

It is probably a piece of broken code (not existing methods etc), as I was running it on an upgraded project.
But since PHPStan passes in all levels (with errors of course), I assumed it would also at least continue to work and report anyway instead of failing hard

If I put a try catch around

    if (!isset($this->methodArguments[$node->name])) {
        $this->currentVariables[$node->name] = true;
    }

I get this for var_dump($node):

object(PhpParser\Node\Expr\Variable)#47657 (2) {
  ["attributes":protected]=>
  array(6) {
    ["startLine"]=>
    int(398)
    ["startTokenPos"]=>
    int(3164)
    ["startFilePos"]=>
    int(16637)
    ["endLine"]=>
    int(398)
    ["endTokenPos"]=>
    int(3167)
    ["endFilePos"]=>
    int(16648)
  }
  ["name"]=>
  object(PhpParser\Node\Expr\Variable)#47658 (2) {
    ["attributes":protected]=>
    array(6) {
      ["startLine"]=>
      int(398)
      ["startTokenPos"]=>
      int(3166)
      ["startFilePos"]=>
      int(16639)
      ["endLine"]=>
      int(398)
      ["endTokenPos"]=>
      int(3166)
      ["endFilePos"]=>
      int(16647)
    }
    ["name"]=>
    string(8) "toRender"
  }
}

So name is an object and cannot be used as key in the array it seems

With this it runs through:

    private function trackVariable(Node\Expr\Variable $node): void
    {
        $name = $node->name;
        if (is_object($node->name)) {
            $name = $node->name->name;
        }

        // Only count variables not already tracked as arguments
        if (!isset($this->methodArguments[$name])) {
            $this->currentVariables[$name] = true;
        }
    }

[dereuromark]

That said:
Neither -r json etc nor -f report.txt etc work
It does not fail but also not write anything to the filesystem or stdout in terms of report.

[floriankraemer]

It does not fail but also not write anything to the filesystem or stdout in terms of report.

I found the issue and I'll fix that one quickly... 😱

[floriankraemer]

@dereuromark I've addressed the issue regarding running the command in https://github.com/Phauthentic/cognitive-code-analysis/releases/tag/1.2.1

There should be no need to pass a report, it should output the result in the console.

[floriankraemer]

@dereuromark I've tried to re-create your issue with the parser and created two classes, one injected into the other one and then calling a non-existent method. This still works for me. I don't mind to apply your fix, but it would be great to figure out a way to test it.

[dereuromark]

Yeah, I coudnt find the toRender() method in the code, so it must come from a dependency.

[dereuromark]

Display works now, but I would expect saving to work too

phpcca analyse src/ -r html -f report.html
Found 434 files. Starting analysis.
434/434 [============================] 100%
PHP Fatal error: Uncaught Error: Typed static property Phauthentic\CognitiveCodeAnalysis\Business\Utility\Datetime::$fixedDate must not be accessed before initialization in /var/www/html/vendor/phauthentic/cognitive-code-analysis/src/Business/Utility/Datetime.php:18

[floriankraemer]

It won't generate the report file because of the runtime error. The report can only be generated after a successful analysis. Without being able to re-create the issue this is going to be hard to fix.

[dereuromark]

The analysis was successful, this issue here is a bug in the business code of the tool and only happens with -f ....

[floriankraemer]

Fixed the uninitialized value and released 1.2.2. please try again.

[dereuromark]

I dont think you properly fixed my issue

Fatal error: Uncaught TypeError: Cannot access offset of type PhpParser\Node\Expr\Variable in isset or empty
still

[floriankraemer]

You reported three different things, this is the last one that remains and I still can't reproduce it. 😟

[floriankraemer]

Can you please try this branch? https://github.com/Phauthentic/cognitive-code-analysis/tree/parser-error-handling

It won't fix the parser, because I can't reproduce it, but should continue the analysis.

Related PR #24