Repository navigation
Update thrust calculation to include StartUT - #14
Merged
Merged
Conversation
Fixes an inconsistency in `ThrustParameters.GetUTAtDeltaV()` when vessel mass change is effectively zero. `GetUTAtDeltaV()` is used as an absolute UT estimate. The normal mass-flow branch returns `StartUT + duration`, but the near-zero-mass-flow branch returned only `duration`: ```csharp return dv * StartMass / thrust; ``` That causes callers such as maneuver-node thrust integration to compute: ```csharp remainingT = Math.Max(estimateUT - parameters.StartUT, 0.0); ``` as zero once `StartUT` is larger than the burn duration. For very low mass-flow or effectively massless thrust cases, this can make maneuver-mode BackgroundThrust believe the burn has no remaining time and immediately reduce timewarp. This patch changes the near-zero-mass-flow branch to return the same absolute time base as the normal branch: ```csharp return StartUT + dv * StartMass / thrust; ```
Owner
|
You know, I had never managed to reproduce this in a debugger. This makes sense here. Thanks for tracking it down! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an inconsistency in
ThrustParameters.GetUTAtDeltaV()when vessel mass change is effectively zero.GetUTAtDeltaV()is used as an absolute UT estimate. The normal mass-flow branch returnsStartUT + duration, but the near-zero-mass-flow branch returned onlyduration:That causes callers such as maneuver-node thrust integration to compute:
as zero once
StartUTis larger than the burn duration. For very low mass-flow or effectively massless thrust cases, this can make maneuver-mode BackgroundThrust believe the burn has no remaining time and immediately reduce timewarp.This patch changes the near-zero-mass-flow branch to return the same absolute time base as the normal branch: