Moved astrometric_align to a combined step #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #99 - Moved astrometric_align to a combined step, to avoid list ordering issues We got 99 issues, but this list ain't one
Collaborator
Author
|
Strange, when I run through with the 2107 config (just swapping the bands to be in ascending order) it works: |
Contributor
|
Confirmed - tweakback seems to be created now for F770W when called with bands out of order. Thank you @thomaswilliamsastro ! |
akleroy
approved these changes
Jan 8, 2026
Contributor
akleroy
left a comment
akleroy
left a comment
There was a problem hiding this comment.
This looks sane (but have not reviewed each line) and I have confirmed it works in the previously failing case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99
We got 99 issues, but this list ain't one