pruntime: Box large value in OrdMap #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to solve the stack overflow issue in pRuntime by boxing the large values in OrdMap.
In the previous implementation, we utilize
OrdMap<H256, Contract>to store the contract info, wheresizeof::<Contract> == 1064. Even though the size of Contract is approximately 1k, theOrdMap::insertdemanded an over 8MB stack in certain scenarios. (Not sure why!)After being boxed, it works fine when 200,000 contracts are deployed, with a 300k stack size.