Unify winner detection implementation into shared package#2
Open
Unify winner detection implementation into shared package#2
Conversation
- Refactored three separate winner detection implementations into single shared function - Updated hasWinner to return BoardCell instead of PlayerType for better reusability - Added findWinningCells function to return winning cell indices - Updated app package to use shared hasWinner function - Updated server package with proper board format conversion - Enhanced test coverage for both functions - All shared tests passing - Fixed TypeScript errors in minimax and hasWinner functions Co-authored-by: Brian Pfretzschner <brianp.de@gmail.com> 💘 Generated with Crush
Pfarrer
force-pushed
the
feature/unify-winner-detection
branch
from
041800e to
5f83b03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasWinnerto returnBoardCellinstead ofPlayerTypefor better reusabilityfindWinningCellsfunction to return winning cell indiceshasWinnerfunctionTest plan
💘 Generated with Crush