Fetch upstream #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#356 "processor signature not working"
consistent naming
In case there are multiple empty tags in xml, they all share reference to the same default object. This causes unwanted duplication, when we assign something to any of these empty objects. When we provide factory function for emptyObject, these objects no longer share reference and works as expected.
Update README.md
parser.test.coffee: regression tests for #356
Bump nodejs versions to ones that are still maintained
Examples:
```js
// Via root API
xml2js.parseStringPromise('< ... >', options)
.then(function (result) { /* ... */ })
.catch(function (err) { /* ... */ })
// Via parser
var parser = new xml2js.Parser(options);
parser.parseStringPromise('< ... >')
.then(function (result) { /* ... */ })
.catch(function (err) { /* ... */ })
```
Parse string promise
Updated events
Update xmlbuilder dependency to 13.x
Restore Node 4 compatibility temporarily
Here we implement the feature without adding an extra dependency.
Remove the temporary util.promisify dependency
complete README example usage
fix issue554, a build error under win10 environment
Allow function as default value for parsing empty tags
Correct a typo
Update README.md
Add documentation for `explicitCharkey` option
use Object.create(null) to create all parsed objects
CVE compat fix
Fix zap to be the original dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.