Merge pull request openshift#14636 from openshift-cherrypick-robot/ch…

…erry-pick-14604-to-release-4.16 [release-4.16] OCPBUGS-46567: ImagePullSecret getting duplicated when editing DeploymentConfig in Form View
PeterYurkovich · Jan 17, 2025 · de0a2d1 · de0a2d1
2 parents 2380f02 + 769ff2b
commit de0a2d1
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/frontend/packages/dev-console/src/components/deployments/utils/deployment-utils.ts b/frontend/packages/dev-console/src/components/deployments/utils/deployment-utils.ts
@@ -595,7 +595,12 @@ export const convertEditFormToDeployment = (
           containers: getUpdatedContainers(containers, fromImageStreamTag, isi, imageName, envs),
           imagePullSecrets: [
             ...(deployment.spec.template.spec.imagePullSecrets ?? []),
-            ...(imagePullSecret ? [{ name: imagePullSecret }] : []),
+            ...(imagePullSecret &&
+            !(deployment.spec.template.spec.imagePullSecrets ?? []).some(
+              (secret) => secret.name === imagePullSecret,
+            )
+              ? [{ name: imagePullSecret }]
+              : []),
           ],
         },
       },