Nginx support with PHP agnostic config #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 2, 2019 16:15
…t driving new doc format.
…sks, changed dokuwiki_plugins_remove variable format. README updated too
…anted tampering via web interface.
…and finished documenting all options.
|
Hi @cacheira - many thanks for your work! I'll be reviewing and testing the changes and get back to you. Could you for next time try to create small, atomic commits and pull requests? This makes reviewing the changes easier and therefore faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I've reviewed this role, added nginx with php-fpm support (and made it version agnostic in debian). Nginx config follows all dokuwiki security requirements.
I've also changed the way plugins and templates are installed (they use dokuwiki's git tool now) and made it so that you only need their name. This works for zip files and tarballs. The plugin config file is also dynamic now.
You can also choose the version of dokuwiki you want to install from stable, oldstable and development and can now configure a bunch of default install options via ansible. Local config was moved for local.protected, to avoid changes via the web interface.
SSL support will be next, it's still not done. I hope these edits are useful.