Fix expiration date conversion when the day is zero #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build is configured to verify the code using JSHint, uglify the code and run tests in the spec folder.
Many manufacturers inform just the month and the year of the expiration date in their barcodes. If that happens, the day usually comes as zero. In such scenario, the date parsing code ends up converting the expiration date to the last day of the previous month. E.g., a barcode contaning 190700 in the date position becomes Jun 30, 2019. It should be converted to Jul 31, 2019, instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many manufacturers inform just the month and the year of the expiration date in their barcodes. If that happens, the day usually comes as zero. In such scenario, the date parsing code ends up converting the expiration date to the last day of the previous month. E.g., a barcode containing 190700 in the date position becomes Jun 30, 2019. It should be converted to Jul 31, 2019, instead.