perf(codegen): re-enter guarded specialization clones - #8290
perf(codegen): re-enter guarded specialization clones#8290proggeramlug wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 8 minutes Limit details: You’ve used all 8 included reviews currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe change extends guarded-path type inference for proven numeric expressions. New recursive fixtures and tests verify direct Tier-B clone re-entry for Number values and guarded fallback for BigInt-capable arithmetic. A changelog entry documents the behavior. ChangesTier-B guarded self-recursion
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: ⚪ Minimal · up to This localized code-generation change includes targeted regression coverage and reported validation checks; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
f(n - 1)edges re-enter the$spec_bclone directly instead of re-running the public parameter guardFixes #8169.
Validation
cargo test -p perry-codegen spec_self_recursion_tests --lib(5 passed)cargo test -p perry-codegen --lib --no-fail-fast(1,067 passed; the two existing Windows temporary-object-name byte-identity tests failed:split_native_construction_lowers_precise_roots_before_rs4gc,split_native_construction_propagates_shadow_backend_to_workers)cargo fmt -p perry-codegen -- --checkpython scripts/check_test_registration.pygit diff --checkNo version bump. The required changelog fragment is included.
Summary by CodeRabbit
Performance
Bug Fixes