fix(runtime): bind static handle method names

[proggeramlug]

Closes #8178.

Summary

js_class_method_bind retains its method-name pointer in the bound closure. The stdlib handle-property dispatchers were forwarding slices backed by the caller's movable GC heap string, so computed method reads could retain an interior pointer after the string moved or died.

• remap SQLite, TLS, EventEmitter, and AsyncLocalStorage method names to &'static [u8] literals before binding
• make the shared stdlib bind helpers accept only static names, so the unsafe call cannot consume a forwarded property slice
• replace the primitive-receiver predicate with a static lookup and route both finite-number guards through one safe-name binder
• add structural pointer-identity tests plus complete method-list coverage for every lookup
• intentionally leave workspace/package versions unchanged

Validation

• cargo test -p perry-runtime --lib handle_bound_method_name -- --nocapture (7 passed)
• cargo test -p perry-stdlib --lib static_method_name -- --nocapture (4 passed)
• RUSTFLAGS="-D warnings" cargo check -p perry-runtime -p perry-stdlib --all-targets
• cargo fmt --all -- --check
• ./scripts/check_file_size.sh
• python3 scripts/ci_plan.py --self-test
• python3 scripts/gc_store_site_inventory.py --self-test && python3 scripts/gc_store_site_inventory.py
• python3 scripts/addr_class_inventory.py --self-test && python3 scripts/addr_class_inventory.py

Summary by CodeRabbit

• Bug Fixes
  • Fixed method access for primitive values and runtime handles so bound methods remain available after garbage collection.
  • Improved method dispatch across event handling, asynchronous storage, database, TLS, and socket APIs.
  • Unknown properties are now rejected more reliably instead of being treated as supported methods.
• Tests
  • Added regression coverage for primitive prototype methods, recognized API methods, and unknown property names.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2915775f-7c19-408c-91e0-cb6f6e611ea7

📥 Commits

Reviewing files that changed from the base of the PR and between 14468dc and 188c9dd.

📒 Files selected for processing (8)

• changelog.d/8284-static-handle-method-names.md
• crates/perry-runtime/src/gc/tests/handle_bound_method_name.rs
• crates/perry-runtime/src/object/field_get_set.rs
• crates/perry-runtime/src/object/field_get_set/get_field_by_name.rs
• crates/perry-runtime/src/object/field_get_set/ic_miss.rs
• crates/perry-stdlib/src/common/dispatch/emitter_als.rs
• crates/perry-stdlib/src/sqlite/dispatch.rs
• crates/perry-stdlib/src/tls/dispatch.rs

Included review availability: Your plan includes up to 8 reviews per rolling hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The runtime and standard-library property dispatchers now resolve supported method names to static byte literals before binding methods. Tests cover primitive numbers, EventEmitter, AsyncLocalStorage, SQLite, and TLS dispatch.

Changes

Static bound-method name resolution

Layer / File(s)	Summary
Primitive prototype binding crates/perry-runtime/src/object/field_get_set/ic_miss.rs, crates/perry-runtime/src/object/field_get_set/get_field_by_name.rs, crates/perry-runtime/src/object/field_get_set.rs, crates/perry-runtime/src/gc/tests/handle_bound_method_name.rs, changelog.d/8284-static-handle-method-names.md	Primitive-number methods now resolve static names before binding. Regression tests cover supported methods, unknown names, and computed-key binding.
Event and async-local dispatch crates/perry-stdlib/src/common/dispatch/emitter_als.rs	EventEmitter and AsyncLocalStorage dispatch use shared static lookup and binding helpers. Tests validate static literals and unknown-name rejection.
SQLite handle dispatch crates/perry-stdlib/src/sqlite/dispatch.rs	Database, tag-store, session, and statement dispatch use shared static method lookups and binding. Tests cover supported names, pointer stability, and unknown properties.
TLS handle dispatch crates/perry-stdlib/src/tls/dispatch.rs	TLS server and socket dispatch use static-name lookups and shared binding. Tests cover supported methods, pointer stability, and unknown names.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: ⚪ Minimal · up to 188c9

The change binds standard-library method names to static storage and includes targeted tests plus repository checks; no actionable merge-blocking risk remains.

Possibly related PRs

• PerryTS/perry#8177: Addresses the same GC-unsafe bound-method name pattern in runtime dispatch.
• PerryTS/perry#7747: Uses static method-name literals for related bound-method dispatch fixes.
• PerryTS/perry#8082: Covers related bound-method GC rooting work in crates/perry-runtime.

Suggested reviewers: thehypnoo

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main runtime fix for static handle method-name binding.
Description check	✅ Passed	The description provides the change summary, linked issue, validation commands, and version-scope clarification.
Linked Issues check	✅ Passed	The changes address the linked interior-pointer bug across SQLite, TLS, EventEmitter, AsyncLocalStorage, and primitive receivers with static-name tests.
Out of Scope Changes check	✅ Passed	The changelog update, refactoring, tests, and validation remain related to the linked static method-name binding fix.
Docstring Coverage	✅ Passed	Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[proggeramlug]

Merging. Runtime 2569 passed / 0 failed / 4 ignored, codegen 28 suites, 1510 passed, 9 failed — all nine baseline, cargo fmt clean, and both named test groups pass: handle_bound_method_name 7/7 and static_method_name 4/4.

The fix is type-level, which is the right kind for this bug. js_class_method_bind retains its name pointer in the bound closure, so a slice backed by a movable GC heap string is a borrowed-heap-slice hazard — the class where rooting cannot help, because the problem is that the borrow outlives the object rather than that the object was collected. Making the shared bind helpers accept only &'static [u8] means the unsafe call cannot consume a forwarded property slice. That makes the bug unrepresentable at those sites rather than merely absent, and it matches the convention already established in domain.rs, crypto/* and string_decoder.rs — this brings sqlite, tls and emitter_als into line.

One note on your validation list: RUSTFLAGS="-D warnings" cargo check -p perry-runtime -p perry-stdlib --all-targets currently fails, but not because of this PR. It was #8294's dead code (register_process_emitter_root_scanner never called, plus unused frame-walk locals). I merged that one earlier today and missed it. Fixed separately in #8298, which also turned out to matter for more than warnings — the scanner really was never registered, so that fix had been inert. Nothing for you to do here.