fix(gc): address bot review followups from #7291, #7281, #7284 - #8257
Conversation
…PerryTS#7284 Three verified bot findings folded into one commit: 1. policy.rs "sound by construction" overclaim (PerryTS#7291 thread): the PerryTS#7280 correction at line 2379 explicitly says the deferral is NOT "sound by construction" because runtime Rust frames need explicit rooting, but the comment at line 2474 still called the same deferral "sound by construction." Aligned it to "makes the collection point precise," matching the corrected framing. 2. gc-rooting-invariant.md "collection #0" imprecision (PerryTS#7281 thread): a runtime cache populated after earlier collections goes bad at the first moving collection after population, not at collection #0. Reworded to state that precisely. 3. 15 untagged TypeScript doc fences (PerryTS#7281 thread): perry-doc-tests --lint reported untagged ts/typescript fences across docs/src. Tagged each as typescript,no-test. Linter now reports "docs/src ok." Refuted (no change needed): - PerryTS#7284 thread claimed docs overclaim --audit-poll-capable CI wiring, but the workflow step was included in the PR squashed commit and is present on main; the docs are accurate. - PerryTS#7281 thread 3 claimed the static-checker scope was unlimited, but the doc already says "Scope: emitted-LLVM rooting hazards only."
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe PR refines GC collection and cache-staleness wording. It also updates selected TypeScript documentation fences to use explicit ChangesDocumentation updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR makes localized documentation and comment corrections without changing product behavior, so no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fix(gc): address bot review followups from #7291, #7281, #7284
Three verified bot findings folded into one commit:
policy.rs "sound by construction" overclaim (fix(gc): root optional parameters, and the instance in runtime-dispatched
new(#7280) #7291 thread): theGC: #7154's residual is NOT fixed — the loop-polls config is red 0/30, and stock zod alone fails 5/40 #7280 correction at line 2379 explicitly says the deferral is NOT
"sound by construction" because runtime Rust frames need explicit
rooting, but the comment at line 2474 still called the same deferral
"sound by construction." Aligned it to "makes the collection point
precise," matching the corrected framing.
gc-rooting-invariant.md "collection #0" imprecision (docs(gc-rooting): #7211 is fixed, and add the runtime-cache class #7281 thread):
a runtime cache populated after earlier collections goes bad at the
first moving collection after population, not at collection #0.
Reworded to state that precisely.
15 untagged TypeScript doc fences (docs(gc-rooting): #7211 is fixed, and add the runtime-cache class #7281 thread): perry-doc-tests
--lint reported untagged ts/typescript fences across docs/src. Tagged
each as typescript,no-test. Linter now reports "docs/src ok."
Refuted (no change needed):
but the workflow step was included in the PR squashed commit and is
present on main; the docs are accurate.
the doc already says "Scope: emitted-LLVM rooting hazards only."
Summary by CodeRabbit
Documentation
Chores