Skip to content

fix(runtime): bind inherited prototype-accessor methods to the receiver, not the prototype #5637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 1 commit into from
Jun 24, 2026
Merged

fix(runtime): bind inherited prototype-accessor methods to the receiver, not the prototype #5637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 40 additions & 3 deletions crates/perry-runtime/src/object/native_call_method/handle_methods.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,10 +891,39 @@ pub(super) unsafe fn dispatch_handle(
method_name.as_ptr(),
method_name.len() as u32,
);
// An inherited method that resolves to an ACCESSOR
// on the prototype must observe the instance as
// `this` (spec `[[Get]](P, Receiver)`), not the
// prototype object the getter lives on. Stash the
// receiver so `invoke_accessor_getter` rebinds it.
// Without this, a schema library's lazily-installed
// `describe`/`clone` accessors — `Object.define-
// Property(proto, k, { get() { const b = fn.bind(this);
// Object.defineProperty(this, k, { value: b }); return b } })`
// on the shared class prototype — run with
// `this === prototype`, bake `this = prototype` into
// the returned bound method, and cache it on the
// prototype. Every downstream read of an
// instance-only field via `this.<field>` then
// returns `undefined` (`Cannot read properties of
// undefined`) even though the instance has it.
// Mirrors `resolve_proto_chain_field_with_receiver`
// (the winston `get transports()` fix).
let receiver_f64 = f64::from_bits(jsval.bits());
let prev_this =
IMPLICIT_THIS.with(|c| c.replace(receiver_f64.to_bits()));
let prev_override =
super::super::field_get_set::accessor_receiver_override_begin(
receiver_f64,
);
let field_val = js_object_get_field_by_name(
proto_obj as *const _,
method_key as *const crate::StringHeader,
);
super::super::field_get_set::accessor_receiver_override_end(
prev_override,
);
IMPLICIT_THIS.with(|c| c.set(prev_this));
if !field_val.is_undefined() && !field_val.is_null() {
resolved_method = Some(ResolvedMethod::ProtoClosure {
field_bits: field_val.bits(),
Expand Down Expand Up @@ -966,9 +995,17 @@ pub(super) unsafe fn dispatch_handle(
method_name.as_ptr(),
method_name.len() as u32,
);
if let Some(field_val) =
resolve_proto_chain_field(class_id, method_key as *const crate::StringHeader)
{
// `_with_receiver` binds an inherited ACCESSOR getter's `this`
// to the instance (not the prototype it lives on), matching the
// ProtoClosure walk above and spec `[[Get]](P, Receiver)`. A
// prototype `Object.defineProperty(proto, k, { get })` reached
// through the registry-`None` (`Object.create(objLiteral)`) path
// would otherwise observe the prototype as `this`.
if let Some(field_val) = resolve_proto_chain_field_with_receiver(
class_id,
method_key as *const crate::StringHeader,
f64::from_bits(jsval.bits()),
) {
if !field_val.is_undefined() && !field_val.is_null() {
// #321 (effect Context/Layer/Scope): the closure we
// just resolved is an *inherited* method — by
Expand Down
Loading