fix(hir): resolve stable-hash Expr tag collision on 12045 (unblocks CI) - #3451
Merged
Merged
Conversation
#3409 (RegExpEscape) and #3402 (ReflectIsExtensible) both merged via a tag race, each assigning stable-hash tag 12045 — making expr_variant_stable_hash_tags_are_unique fail on main and blocking all PR CI. Reassign ReflectIsExtensible to the free tag 12048 (matches the fix already on PR #3445's branch, so no future conflict).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainis currently RED onstable_hash::tests::expr_variant_stable_hash_tags_are_unique. Two HIRExprvariants both got assigned stable-hash tag 12045 via a merge race:Expr::RegExpEscape(fix(buffer): expose namespace constructors and backing properties #3409)Expr::ReflectIsExtensible(fix(reflect): correct return values for set/get/define/delete/extensibility #3402)Each PR's CI passed because the other variant wasn't on
mainyet at test time. With both merged, the uniqueness assertion fails — and since this is a workspace unit test, every open PR'scargo-testnow fails, blocking the entire merge queue.Fix
Reassign
ReflectIsExtensiblefrom12045→12048(next free tag; 12046/12047 taken, 12048+ free). This matches the fix already present on PR #3445's branch, so no future conflict when that lands.Verified locally:
cargo test -p perry-hir stable_hash→ 6 passed/0 failed; build + fmt clean.