fix(error): construct EvalError and URIError - #2911
Merged
proggeramlug merged 2 commits intoMay 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2885.
Summary:
EvalErrorandURIErrorErrorHeader kinds, runtime constructors, and reserved instanceof class ids.new EvalError(...)/new URIError(...),new globalThis.EvalError(...), and rebound global constructor construction through the native Error allocation path..namefor the EvalError/URIError global constructor closures and include them in built-in error constructor matching..name/.message, direct/static instanceof, dynamic instanceof, globalThis construction, empty-message construction, and rebound construction.Parity evidence:
eval direct name: undefinedfor the new fixture.test-parity/reports/parity_report_20260530_021600.json.Verification:
PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH node --experimental-strip-types test-parity/node-suite/globals/error-eval-uri-constructors.tsPATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH RUSTC_WRAPPER= ./run_parity_tests.sh --suite node-suite --module globals --filter error-eval-uri-constructorscargo fmt --all -- --checkjq empty test-parity/known_failures.json test-parity/threshold.jsongit diff --check && git diff --cached --checkRUSTC_WRAPPER= cargo check -p perry-hir -p perry-codegen -p perry-runtimeRUSTC_WRAPPER= cargo test -p perry-runtime eval_and_uri_errors_have_distinct_kinds_and_names -- --test-threads=1Known verification issue:
./scripts/check_file_size.shcurrently fails on existing base-statecrates/perry-runtime/src/node_stream_readwrite.rsat 2001 lines; this branch does not touch that file.