fix(runtime): reject new Symbol and BigInt - #2903
Merged
proggeramlug merged 7 commits intoMay 30, 2026
Merged
Conversation
# Conflicts: # crates/perry-codegen/src/runtime_decls/strings.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new Symbol(...)andnew BigInt(...)to Node-compatible TypeErrors after evaluating constructor argumentsglobalThis.Symbol/globalThis.BigIntmember constructor forms in HIR loweringjs_new_function_constructinstead of returning placeholders or crashingCloses #2883
Validation
PATH="/root/.npm/_npx/8758e404b5eed2f3/node_modules/.bin:$PATH" node --experimental-strip-types test-parity/node-suite/globals/symbol-bigint-new-throws.tsenv RUSTC_WRAPPER= PATH="/root/.npm/_npx/8758e404b5eed2f3/node_modules/.bin:$PATH" ./run_parity_tests.sh --suite node-suite --module globals --filter symbol-bigint-new-throws(test-parity/reports/parity_report_20260530_020504.json)env RUSTC_WRAPPER= cargo check -p perry-hir -p perry-codegen -p perry-runtimecargo fmt --all -- --checkgit diff --checkgit diff --cached --checkjq empty test-parity/known_failures.json test-parity/threshold.jsonPre-fix focused parity failed and the alias path crashed:
test-parity/reports/parity_report_20260530_015442.json.Note:
./scripts/check_file_size.shcurrently fails oncrates/perry-runtime/src/node_stream_readwrite.rsat 2001 lines; that file is unchanged by this PR and is already 2001 lines onorigin/main.