Skip to content

fix(node:os): stabilize constants namespace identity - #1887

Merged
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-os-constants-identity
May 27, 2026
Merged

fix(node:os): stabilize constants namespace identity#1887
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-os-constants-identity

Conversation

@andrewtdiz

Copy link
Copy Markdown
Contributor

Summary

  • cache node:os constants namespace objects so repeated os.constants and nested constants reads preserve identity
  • add the new cached namespace roots to the runtime object-cache GC scanner and root rewrite test
  • save the Deno node:os constants reference used for this slice

Verification

  • cargo fmt --all --check
  • cargo check -p perry-runtime
  • cargo test -p perry-runtime test_gc_init_mutable_scanner_families_rewrite_runtime_slots
  • ./scripts/check_file_size.sh
  • ./scripts/regen_api_docs.sh
  • ./run_parity_tests.sh --suite node-suite --module os --filter eol-and-constants-identity
  • ./run_parity_tests.sh --suite node-suite --module os --filter constants
  • ./run_parity_tests.sh --suite node-suite --module os (34 pass / 5 fail; remaining failures are unrelated existing gaps, with userinfo/encoding-buffer covered by fix(node:os): return buffers for userInfo buffer encoding #1884)

@proggeramlug
proggeramlug merged commit 67695c9 into PerryTS:main May 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants