feat(process): implement process.execArgv (#1349) - #1468
Merged
Conversation
Node's `process.execArgv` is the array of CLI flags the interpreter was started with. Perry was returning the property as a 0 sentinel, so `Array.isArray(process.execArgv)` was `false` and any `.length` / iteration crashed. Perry binaries are AOT — there's no runtime flag list to forward — so the empty array is the correct shape. Lowered in `expr_member.rs` (both the bare `process.execArgv` and the `globalThis.process.execArgv` paths) to `Expr::Array(Vec::new())`. Test: test-parity/node-suite/process/exec-argv/exec-argv.ts asserts shape (Array.isArray + every-string + length type) so it stays parity- clean regardless of which flags Node was invoked with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node's
process.execArgvis the array of CLI flags the interpreter was started with. Perry was returning the property as a 0 sentinel, so:Array.isArray(process.execArgv)returnedfalse.length/ iteration crashed with type errorsPerry binaries are AOT — there's no runtime flag list to forward — so the empty array is the correct shape. Closes #1349.
Changes
expr_member.rs: both the bareprocess.execArgvand theglobalThis.process.execArgvpaths now lower toExpr::Array(Vec::new()), sitting next to the existingargv/versions/ IPC-undefined arms.Test plan
test-parity/node-suite/process/exec-argv/exec-argv.tsasserts shape (Array.isArray+ every-string +lengthtype) so it stays parity-clean regardless of which flags Node was invoked with.node --experimental-strip-types.cargo fmt --all -- --checkclean.