Expand Node parity test coverage - #1315
Merged
Merged
Conversation
This was referenced May 22, 2026
TheHypnoo
marked this pull request as ready for review
May 22, 2026 09:07
proggeramlug
added a commit
that referenced
this pull request
May 22, 2026
…sweep (#1414) Rolls up 26 PRs that merged to main post-v0.5.1023 without version bumps: - node:crypto gap-fixes (#1386 #1393 #1394 #1402 #1405): randomInt, timingSafeEqual, getHashes/getCiphers, sha224/sha384, base64 digest, Buffer hash input, no-arg digest() → Buffer, pbkdf2Sync digest arg, scryptSync. - node:perf_hooks (#1321 + #1328 #1342 coverage): performance + User Timing + PerformanceObserver native impl, granular node-suite + edge-case coverage. - #1090 GC checkpoint runtime work (#1324). - #1311 geisterhand on iOS (#1316 #1383 #1384 #1385). - #1312 process.env.X (unset) is nullish undefined (#1314). - #1319 thread-safety hardening for cross-thread runtime statics. - #1322 exact-head GC evidence packet. - #1323 wasm timers dispatch through mem_call bridge (#1329). - #1317 node:timers/promises shadow-segfault fix (#1326). - #1330 node:process suite (#1331). - #1292 bcrypt.hash() returns String (#1307). - #1293 fastify .json()/.body external-fastify dispatch (#1308). - #1296 app pattern performance gaps. - #1297 diagnostics_channel parity. - #1301 iOS App Groups capability (#1313). - #1318 #1325 os/methods/modern-methods static dispatch. - #1315 expanded Node parity test coverage. - #1382 ui-ios stdlib pump for async fetch. - #1392 ui-wasm reactive state + setText (#1404).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the curated
test-parity/node-suitecoverage for the modules that were already under test, without introducing new modules and without expandingobject.This PR adds 184 new Node parity tests across existing module directories:
assertbufferconsolediagnostics_channeleventsospathquerystringstring_decodertimersttyurlutilThe suite grows from 611 to 795 tests.
What changed
Added focused edge-case coverage for:
Consoleinstances, object labels, grouping, tables, getters, proxy-like shapes, private fields, error causes, and circular/BigInt formattersonce/on, static listener helpers, and max listener behaviorValidation performed
New tests were validated against Node 22.15.0 with:
Repository checks run locally:
Full node-suite parity run against Perry:
Result:
Gaps surfaced by the expanded suite
The expanded suite identifies 116 total parity gaps:
By module:
utilbuffertimersconsoleurleventsassertpathosquerystringdiagnostics_channelstring_decoderttyobjectMain behavior buckets found:
util: inspect rendering, util.types predicates, parseArgs, promisify/callbackify/deprecate, format/formatWithOptions optionsbuffer: Buffer.from coercion, ArrayBuffer offsets, SharedArrayBuffer, encodings, concat length handling, fill/write validation, inspect constantstimers: timers/promises abort behavior, interval async iterator, scheduler aborts, timer object methods/disposal, callbackthis, ordering, one segfault in a promises timeout caseconsole: custom Console streams, object label coercion, getter/sorted inspect, class private field output, circular/BigInt formattingurl: URL mutation/escaping, URLSearchParams constructors and thisArg, file URL Unicode/errors, legacy format/parse edge casesevents: abort/error behavior, captureRejections, errorMonitor, addAbortListener, symbol/eventNames, once/on semanticsassert: deep equality for Error cause, Map/Set, partial deep equality, typed arrays, throws/rejects failure behaviorpath: win32/UNC behavior, type validation, normalization, parse, toNamespacedPath, matchesGlobos: priority methods, networkInterfaces/loadavg/cpus/userInfo/devNull shapes, dynamic namespace dispatch compile guardquerystring: custom decoder, missing values, symbol/non-enumerable keysdiagnostics_channel: subscriber error ordering and traceCallback error-first behaviorstring_decoder: encoding normalization and utf16le compile pathtty: TTY constructor and color/class shapeCompile failures surfaced:
Known root causes from local run:
buffer/search/ucs2-and-buffer-needle:utf16leis not recognized in that Buffer encoding lowering path.string_decoder/utf16le/surrogate-boundaries: sameutf16leencoding path issue.os/methods/modern-methods: dynamic stdlib namespace dispatch (os[name]()) is intentionally blocked by Perry's safety guard.Suggested follow-up work
This PR intentionally keeps the scope to test coverage. Follow-up implementation work can be split by root cause/module:
os/methods/modern-methodsURLSearchParams.forEach(thisArg)utilbuffertimersurleventsconsoleassertpathosNotes
This is opened as a draft because the expanded
node-suiteintentionally exposes current Perry parity gaps. The PR is intended as a coverage/visibility step before implementation-focused PRs.