Make 'CombCov.get_subrules()' a generator #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_subrules() a little bit smarted by not returning subrules with empty columns or rows (as they're duplicate of smaller MeshTilings)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the function returning a list of all subrules, it's better to make it into a generator returning each rule as it's generated. This saves memory and opens up for the possibility of parallelising the rule generation (
MeshTiling,StringSetand other such objects) and bitstring creation (CombCov).Also made MeshTiling.get_subrules() a little bit smarted by discarding subrules with empty column or row as those are duplicates of other MeshTilings of lower dimension.