-
-
Notifications
You must be signed in to change notification settings - Fork 251
fix: ensure database migration errors are returned #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure database migration errors are returned #1508
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe recent updates involve a minor version increment of the Permify API from "v1.0.2" to "v1.0.3" across multiple documentation files and constants. Additionally, the error handling logic in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pkg/pb/base/v1/openapi.pb.go
is excluded by!**/*.pb.go
Files selected for processing (5)
- docs/api-reference/apidocs.swagger.json (1 hunks)
- docs/api-reference/openapiv2/apidocs.swagger.json (1 hunks)
- internal/info.go (1 hunks)
- pkg/cmd/serve.go (1 hunks)
- proto/base/v1/openapi.proto (1 hunks)
Files skipped from review due to trivial changes (4)
- docs/api-reference/apidocs.swagger.json
- docs/api-reference/openapiv2/apidocs.swagger.json
- internal/info.go
- proto/base/v1/openapi.proto
Additional comments not posted (1)
pkg/cmd/serve.go (1)
268-268
: Ensure proper error propagation in database migration.The modification to return the error directly after logging it is a significant improvement. This change ensures that errors during the database migration are not just logged but also returned, allowing the calling function to handle them appropriately.
This aligns with the PR's objective to enhance error handling by making sure migration errors are properly propagated.
Summary by CodeRabbit