-
Notifications
You must be signed in to change notification settings - Fork 1
[PER-10371] Unlisted share record preview fixes #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
50b969c to
bc63984
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
==========================================
- Coverage 47.15% 47.13% -0.03%
==========================================
Files 372 372
Lines 11495 11498 +3
Branches 1912 1913 +1
==========================================
- Hits 5421 5420 -1
- Misses 5889 5896 +7
+ Partials 185 182 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The test coverage is failing and there is indeed a test that I would need to add, but that won't raise the code coverage too much. The reason I am not able to add the test is because I would need to refactor the way the setup for testing is made(beforeEach) in order to be able to dynamically give values to the mockRoute.snapshot.sharePreviewVO. |
cecilia-donnelly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "My Archive" appears as expected, but clicking it doesn't do anything. That check is outside the test cases in the PR, so potentially it could be a separate piece of work, but I think showing a non-functional button instead of no button is a regression.
I tested with an account that only has one archive.
Indeed, the button does not work, but the issue is fixed in the fallback PR that's in testing: #836 |
When previewing a record as an unlisted share, the folder cannot be retrieved because the logged in user does not have rights to view it. This is why we need to create a mock folder that will be saved in the data service and be used accross the components from the share flow. Issue: PER-10371 Unlisted share record preview broken
When previewing an unlisted share record, we need a mock folder for it to be stored in the data service and provide it to different components from the share flow. When creating it, we should use the thumbnails from the current record if that is available or else use generated previews. Issue: PER-10371 Unlisted share record preview broken
babcb4f to
5a4c06b
Compare
Jira bug: https://permanent.atlassian.net/browse/PER-10371
STEPS TO TEST
Record as unlisted share, no account:
EXPECTED: The preview of the record will appear, with the correct thumbnail
EXPECTED: The modal with details will appear, click on the download button/resize buttons
Record as unlisted share, with account:
EXPECTED: The preview of the record will appear, with the correct thumbnail, My Archive button and thumbnail will be present
EXPECTED: The modal with details will appear, click on the download button/resize buttons
OBSERVATION: Other scenarios could be tested, just to make sure share works correctly: