avoid unitialized warnings when resolving extra compiler/link flags i… #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n xs_ok xs_ok merges the compile and link flags passed to it with those provided by ExtUtils::CppGuess. It assumes that if there are extra flags returned by ExtUtils::CppGuess, then there are also extra flags passed to xs_ok. On some systems, this assumption does not hold, and results in undefined values being passed to Text::ParseWords::shellwords when parsing extra flags passed to xs_ok, causing warnings such as use of uninitialized value $line in substitution (s///) at .../Text/ParseWords.pm line 21. to be emitted.
plicease
approved these changes
Jan 4, 2025
|
Great, thanks! Headed to CPAN as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n xs_ok
xs_ok merges the compile and link flags passed to it with those provided by ExtUtils::CppGuess. It assumes that if there are extra flags returned by ExtUtils::CppGuess, then there are also extra flags passed to xs_ok.
On some systems, this assumption does not hold, and results in undefined values being passed to Text::ParseWords::shellwords when parsing extra flags passed to xs_ok, causing warnings such as
use of uninitialized value $line in substitution (s///) at .../Text/ParseWords.pm line 21.
to be emitted.