Skip to content

Add additional CVE versions #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

clscott
Copy link

@clscott clscott commented May 14, 2025

@plicease
Copy link
Member

plicease commented May 14, 2025

Thanks, can you add the CVE numbers next to the impacted versions in the alienfile as comments. I know we haven't done that in the past but will help understand why without git archeology.

CI failures are not you I will fix shortly.

@plicease
Copy link
Member

Okay I fixed CI in main, can you please also rebase this onto main?

@plicease plicease requested a review from shawnlaffan May 14, 2025 14:58
@shawnlaffan
Copy link
Contributor

The code change looks good.

That said, the CVEs are for the python bindings (details in https://gitlab.gnome.org/GNOME/libxml2/-/issues/889 ) so should not affect Alien::Libxml2 users unless they are then calling python code.

There is also the knock on effect that XML::LibXML2 has test failures for libxml2 2.13 and presumably 2.14.
https://rt.cpan.org/Ticket/Display.html?id=156899
https://rt.cpan.org/Ticket/Display.html?id=157693

And finally, XML::LibXML is up for adoption: shlomif/perl-XML-LibXML#91

@shawnlaffan
Copy link
Contributor

Although now I reread the CVE and the code, the CVE lists all versions up to 2.13.8, including the 2.12 series. So the code change does not account for 2.12.10. However, doing so would cause the issues I raised above.

I'm hoping to get a Strawberry Perl 5.38.4 release out shortly and releasing such a change would certainly complicate matters given XML::LibXML2 is packaged with SP...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants