Silence various compiler warnings on MingW #23896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
khwilliamson
commented
Nov 2, 2025
khwilliamson
commented
- This set of changes does not require a perldelta entry.
The compiler used on MingW doesn't realize that there is no path that keeps this from being initialized
khwilliamson
force-pushed
the
mingw
branch
3 times, most recently
from
a7f460d to
d7350e3
Compare
tonycoz
reviewed
Nov 3, 2025
win32/perllib.c
Outdated
Comment on lines
266
to
267
| PERL_UNUSED_ARG(lpvReserved); | ||
|
|
Contributor
There was a problem hiding this comment.
perllib.c is C++, we can just omit the lpvReserved in LPVOID lpvReserved.
Contributor
|
Looks good otherwise. |
These should silence warnings on MingW.
This silences a compiler warning
This should be in a comment even though the compilers on Windows tolerate it, but with a warning
Make this macro more legible, while silencing some compiler warnings about the if statements looking like they are intended to apply to more than they actually do.
We have macros that including perl.h gets us access to, and do the same thing more quickly than this did.
The MingW compiler spotted this. The code prior to these uses already has made sure these indices are positive, so casting to unsigned works.
The MingW compiler thinks this can be used unininitalized, even though I don't think it can. Just initialize it to 0.
The MingW compiler thinks this can be used unininitalized.
The MingW compiler thinks this can be used unininitalized
to silence a compiler warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.