op/magic.t clearing %ENV now z/OS safe except in ASCII mode #23892
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeenan
reviewed
Nov 2, 2025
| $0 = Cygwin::win_to_posix_path(Cygwin::posix_to_win_path($0, 1)); | ||
| EOX | ||
| } | ||
| if ($^O eq 'os390' or $^O eq 'posix-bc') { # no shebang |
Contributor
There was a problem hiding this comment.
Why have you dropped $^O eq 'os390' or from this if branch?
Contributor
Author
There was a problem hiding this comment.
Good catch; that is a separate commit
Contributor
Author
There was a problem hiding this comment.
so, this p.r. is now revised to just be what the commit message implied, and that message is clarified
So no need to skip this test, except when run under ASCII
khwilliamson
force-pushed
the
ebcdic_magic.t
branch
from
e00ab96 to
6eed90b
Compare
khwilliamson
changed the title
jkeenan
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So no need to skip this test, except when run under ASCII