Skip to content

Implement named parameters in signatures (PPC0024) #23871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: blead
Choose a base branch
from
+2,191 −1,445
Open

Implement named parameters in signatures (PPC0024) #23871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d3cc8bc
Implement named parameters in signatures (PPC0024)
leonerd Oct 8, 2025
22577bb
fixup use croak_caller() to report correct caller line number
leonerd Oct 23, 2025
cac9d2d
fixup typo in perlsub.pod
leonerd Oct 23, 2025
6b48617
fixup correct handling of slurpy hash on odd number of elements
leonerd Oct 23, 2025
429c970
fixup permit unnamed slurpy mixed with named params
leonerd Oct 23, 2025
f879698
fixup named->namepv should be saveshared
leonerd Oct 23, 2025
19e0675
fixup better error reporting of non-scalar vars used as named params
leonerd Oct 23, 2025
380cddc
fixup forbid duplicate parameter names
leonerd Oct 23, 2025
c22445a
fixup forbid mandatory named params after optional positional ones
leonerd Oct 23, 2025
42922c3
fixup correct handling of non-ASCII parameter names
leonerd Oct 23, 2025
26bb47a
fixup neater code in op.c
leonerd Oct 23, 2025
2a77bc0
fixup declare is_required as bool, not int
leonerd Oct 23, 2025
7a7a5b4
fixup ensure signature named params works for anon subs too
leonerd Oct 24, 2025
5585e35
fixup more unit tests inspired by remaining comments in PPC0024
leonerd Oct 24, 2025
37a1016
fixup small wording fixes in perlsub.pod
leonerd Oct 25, 2025
222457b
fixup minor docs fixes
leonerd Oct 27, 2025
7cc7882
fixup don't UTF8-upgrade caller argument strings
leonerd Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dump.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1804,6 +1804,11 @@ S_do_op_dump_bar(pTHX_ I32 level, UV bar, PerlIO *file, const OP *o,
S_opdump_indent(aTHX_ o, level, bar, file, " PARAM [%zd] ANON\n",
i);
}
for(size_t i = 0; i < aux->n_named; i++) {
struct op_multiparam_named_aux *named = aux->named + i;
S_opdump_indent(aTHX_ o, level, bar, file, " NAMEDPARAM <%.*s> PADIX = %" UVuf "%s\n",
named->namelen, named->namepv, named->padix, named->is_required ? "" : " OPT");
}

if(aux->slurpy)
S_opdump_indent(aTHX_ o, level, bar, file, "SLURPY = '%c' PADIX = %" UVuf "\n",
Expand Down
5 changes: 5 additions & 0 deletions embed.fnc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3209,6 +3209,11 @@ p |void |sub_crush_depth|NN CV *cv
: Used in perly.y
p |void |subsignature_append_fence_op \
|NN OP *o
p |void |subsignature_append_named \
|NN const char *paramname \
|PADOFFSET padix \
|OPCODE defmode \
|NULLOK OP *defexpr
p |void |subsignature_append_positional \
|PADOFFSET padix \
|OPCODE defmode \
Expand Down
1 change: 1 addition & 0 deletions embed.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,6 +1163,7 @@
# define sighandler3 Perl_sighandler3
# define sub_crush_depth(a) Perl_sub_crush_depth(aTHX_ a)
# define subsignature_append_fence_op(a) Perl_subsignature_append_fence_op(aTHX_ a)
# define subsignature_append_named(a,b,c,d) Perl_subsignature_append_named(aTHX_ a,b,c,d)
# define subsignature_append_positional(a,b,c) Perl_subsignature_append_positional(aTHX_ a,b,c)
# define subsignature_append_slurpy(a,b) Perl_subsignature_append_slurpy(aTHX_ a,b)
# define subsignature_finish() Perl_subsignature_finish(aTHX)
Expand Down
337 changes: 172 additions & 165 deletions lib/warnings.pm
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading