Migrate more signatures warn/croak tests to t/lib/* #23868
Merged
+37
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycoz
reviewed
Oct 21, 2025
Comment on lines
+1
to
+2
| # PREAMBLE use warnings; | ||
| # PREAMBLE use feature 'signatures'; |
Contributor
There was a problem hiding this comment.
I thought I'd missed this feature when writing up t/test_pl.pod, but it looks like someone snuck it in afterwards :)
I'll update t/test_pl.pod.
Contributor
Author
There was a problem hiding this comment.
Oh, I only added it a couple of weeks ago :)
tonycoz
approved these changes
Oct 21, 2025
Contributor
|
I had a quick look at this p.r. today and hope to examine it more closely in the next two days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I moved a few of the custom ad-hoc tests of compile-time failures out of
t/op/signatures.tinto the dedicated infrastructure oft/lib/croak. Here's a few more movements, and also some warnings tests as well.This is a prerequisite for my
signature-named-paramsbranch.