Use PerlLIO_dup_cloexec in Perl_dirp_dup to set O_CLOEXEC #23361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dup doesn't mark the new descriptor as close-on-exec, which can lead to a descriptor leaking to the new process.
khwilliamson
approved these changes
Jun 9, 2025
ilmari
approved these changes
Jun 9, 2025
|
@steve-m-hay This should be applied to maint-5.38 and maint-5.40 before the security release. (Aside from this we also need a perldelta entry before they can ship.) |
Cherry-picked as required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dupdoesn't mark the new descriptor as close-on-exec, which can lead to a descriptor leaking to the new process.