[Win32] Set $Config{installsitescript} to a sane value. #22581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both "win32/config.gc" and "win32/config.vc" currently assign the empty string to
installsitescript
.This led to the failing test in Module-Build-Tiny-0.048 reported at Perl-Toolchain-Gang/module-build-tiny#35.
Both
installbin
andinstallsitebin
are currently assigned the value~INST_TOP~~INST_VER~\bin~INST_ARCH~
and this PR assigns that same value toinstallsitescript
- which fixes that failing Module-Build-Tiny test.This PR also corrects
installscript
(which was previously missing the~INST_ARCH~
appendage) so that it, too, becomes identical to the other three.AIUI, Strawberry Perl is unaffected by anything we change here, as their build procedure sets these Config values independently of the win32/config.gc specification.
I'm not sure whether the 2 "site" variants should specify
\site\bin
instead of just\bin
.I've left it as just
\bin
, mainly becauseperl\site\bin
is generally (always?) non-existent when a fresh build of Windows perl is installed, and people might not realize that they have to add that non-existent directory to the path ... and then spend hours trying to work out why some subsequently installed module has apparently failed to install its "scripts".Besides, the current setting for
installsitebin
has not led to any report of problems (AFAIK), so why change it ?I am, of course, open to suggestions wrt this.