Silence inconsequential warnings in win32/perlhost.h. #22006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeenan
added
type-win32build
|
These functions are all called via a table of function pointers, and the callers supply that first parameter. They aren't used currently in perl, but that could change in the future, it's possible they're used by the ActivePerl ISAPI plugin. |
tonycoz
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why these functions that are emitting the warnings are even declared in perlhost.h.
And I don't know why they insist on taking an unused arg.
Maybe there's a better approach to silencing these warnings than the one I have chosen.
Anyway, they silence the warnings for me, and don't break anything in the process (AFAICS).
Hopefully, the CI tests will confirm this.