Skip to content

win32/Makefiles: don't try to be clever with modification times #21684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

tonycoz
Copy link
Contributor

@tonycoz tonycoz commented Dec 4, 2023

When I re-worked this I tried to reduce the amount of rebuilding needed in some cases, but this has caused other problems, so simplify.

Fixes #21680

When I re-worked this I tried to reduce the amount of rebuilding
needed in some cases, but this has caused other problems, so
simplify.

Fixes Perl#21680
@sisyphus
Copy link
Contributor

sisyphus commented Dec 4, 2023

Fixes #21680

Yes - fixes it for me, too.

@khwilliamson
Copy link
Contributor

I probably won't have a chance to check this out, but if it works for @sisyphus , it sounds good to me

@khwilliamson
Copy link
Contributor

Actually, I did test this, and found one issue, at least. It appears that some dependencies aren't getting found. If I touch perl.h, it rebuilds many objects, as you would expect. But I happened to just change locale_table.h, and no C files at all were recompiled. I wonder what other hdrs are somehow not having their dependencies properly built

@tonycoz
Copy link
Contributor Author

tonycoz commented Dec 10, 2023

Actually, I did test this, and found one issue, at least. It appears that some dependencies aren't getting found. If I touch perl.h, it rebuilds many objects, as you would expect. But I happened to just change locale_table.h, and no C files at all were recompiled. I wonder what other hdrs are somehow not having their dependencies properly built

There's no dependency scan (make depend) on Windows, the dependencies on header files is done by making all objects depend on all headers:

# We can't have miniperl.exe depend on git_version.h, as miniperl creates it
$(MINI_OBJ)	: $(MINIDIR)\.exists $(CORE_NOCFG_H)

$(WIN32_OBJ)	: $(CORE_H)

$(CORE_OBJ)	: $(CORE_H)

$(DLL_OBJ)	: $(CORE_H)

and CORE_NOCFG_H (used in the CORE_H definition) doesn't include locale_table.h.

@tonycoz tonycoz merged commit 973d1d3 into Perl:blead Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't make on Windows except from scratch
3 participants