Pod simple 3.45 sync 20230802 #21326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synch Pod-Simple-3.45 into blead, without (yet) correcting the two test failures reported in Perl#21311. There are test failures in t/porting/cmp_version.t and ext/Pod-Html/t/anchorify.t.
Solely for the purpose of keeping t/porting/cmp_version.t happy.
I pulled code from Pod::Simple::XHMTL::idify() into anchorify(). Increment $VERSION to 1.35 to keep t/porting/cmp_version.t happy.
jkeenan
added
ext/Pod-Html
haarg
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
I've reviewed this again, and realized that the anchorify function only has exactly one user, the installhtml script, which uses it to generate file names for the --splithead option. The --splithead option is only used for a single file: perlipc.pod. It is not used by anything on CPAN.
Since it is generating file names, not internal anchors, I think it makes sense for it to have its own implementation, not being tied directly to what Pod::Simple::XHTML uses for anchors.
This looks like the correct solution to me.
khwilliamson
approved these changes
Aug 4, 2023
|
Merged, but unfortunately I forgot to squash commits before I did the merge. (Those GH buttons are sometimes too easy and too tempting.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch completes the synching into blead of Pod-Simple-3.45. This synching had to be reverted because of a side effect failure in
ext/Pod-Html/t/*.t. (It's admittedly kludgy -- but so is most of Pod-Html.)Fixes #21311