BBC: Blead breaks DOHERTY/App-perlhl-0.007.tar.gz

[andk]

Description

A {given,when} is deprecated case. Report: http://www.cpantesters.org/cpan/report/a44ee834-ca72-11ed-9084-8776edfa6a89

Steps to Reproduce

cpan -i DOHERTY/App-perlhl-0.007.tar.gz

Expected behavior

Perl configuration

# perl -V output goes here
Summary of my perl5 (revision 5 version 37 subversion 10) configuration:
  Commit id: d62f5d9eddd273f5a82c0dbad932a8f4d18f9488
  Platform:
    osname=linux
    osvers=5.19.0-35-generic
    archname=x86_64-linux-ld
    uname='linux k93jammy 5.19.0-35-generic #36~22.04.1-ubuntu smp preempt_dynamic fri feb 17 15:17:25 utc 2 x86_64 x86_64 x86_64 gnulinux '
    config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/host/k93jammy/v5.37.10/5674 -Dmyhostname=k93jammy -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Uuseithreads -Duselongdouble -DEBUGGING=-g'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=define
    use64bitall=define
    uselongdouble=define
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='cc'
    ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
    optimize='-O2 -g'
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='11.3.0'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='long double'
    nvsize=16
    Off_t='off_t'
    lseeksize=8
    alignbytes=16
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/x86_64-linux-gnu /usr/lib /usr/lib64
    libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=/lib/x86_64-linux-gnu/libc.so.6
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version='2.35'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'


Characteristics of this binary (from libperl): 
  Compile-time options:
    HAS_TIMES
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_HASH_FUNC_SIPHASH13
    PERL_HASH_USE_SBOX32
    PERL_MALLOC_WRAP
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    PERL_USE_DEVEL
    PERL_USE_SAFE_PUTENV
    USE_64_BIT_ALL
    USE_64_BIT_INT
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_COLLATE
    USE_LOCALE_CTYPE
    USE_LOCALE_NUMERIC
    USE_LOCALE_TIME
    USE_LONG_DOUBLE
    USE_PERLIO
    USE_PERL_ATOF
  Built under linux
  Compiled at Mar 21 2023 11:44:29
  %ENV:
    PERL="/tmp/basesmoker-reloperl-niLM/bin/perl"
    PERL5LIB="/tmp/loop_over_bdir-1601045-niXMfj/Lingua-BioYaTeA-0.11-0/blib/arch:/tmp/loop_over_bdir-1601045-niXMfj/Lingua-BioYaTeA-0.11-0/blib/lib:/tmp/loop_over_bdir-1601045-niXMfj/Lingua-YaTeA-0.626-0/blib/arch:/tmp/loop_over_bdir-1601045-niXMfj/Lingua-YaTeA-0.626-0/blib/lib:/tmp/loop_over_bdir-1601045-niXMfj/Dpkg-1.21.19-0/blib/arch:/tmp/loop_over_bdir-1601045-niXMfj/Dpkg-1.21.19-0/blib/lib:/tmp/loop_over_bdir-1601045-niXMfj/App-oo_modulino_zsh_completion_helper-0.04-0/blib/arch:/tmp/loop_over_bdir-1601045-niXMfj/App-oo_modulino_zsh_completion_helper-0.04-0/blib/lib:/tmp/loop_over_bdir-1601045-niXMfj/ProjectBuilder-0.14.1-0/blib/arch:/tmp/loop_over_bdir-1601045-niXMfj/ProjectBuilder-0.14.1-0/blib/lib:/tmp/loop_over_bdir-1601045-niXMfj/Lemonldap-NG-Cli-0.2-0/blib/arch:/tmp/loop_over_bdir-1601045-niXMfj/Lemonldap-NG-Cli-0.2-0/blib/lib"
    PERL5OPT=""
    PERL5_CPANPLUS_IS_RUNNING="1601116"
    PERL5_CPAN_IS_RUNNING="1601116"
    PERL_CANARY_STABILITY_NOPROMPT="1"
    PERL_MM_USE_DEFAULT="1"
    PERL_USE_UNSAFE_INC="1"
  @INC:
    /tmp/loop_over_bdir-1601045-niXMfj/Lingua-BioYaTeA-0.11-0/blib/arch
    /tmp/loop_over_bdir-1601045-niXMfj/Lingua-BioYaTeA-0.11-0/blib/lib
    /tmp/loop_over_bdir-1601045-niXMfj/Lingua-YaTeA-0.626-0/blib/arch
    /tmp/loop_over_bdir-1601045-niXMfj/Lingua-YaTeA-0.626-0/blib/lib
    /tmp/loop_over_bdir-1601045-niXMfj/Dpkg-1.21.19-0/blib/arch
    /tmp/loop_over_bdir-1601045-niXMfj/Dpkg-1.21.19-0/blib/lib
    /tmp/loop_over_bdir-1601045-niXMfj/App-oo_modulino_zsh_completion_helper-0.04-0/blib/arch
    /tmp/loop_over_bdir-1601045-niXMfj/App-oo_modulino_zsh_completion_helper-0.04-0/blib/lib
    /tmp/loop_over_bdir-1601045-niXMfj/ProjectBuilder-0.14.1-0/blib/arch
    /tmp/loop_over_bdir-1601045-niXMfj/ProjectBuilder-0.14.1-0/blib/lib
    /tmp/loop_over_bdir-1601045-niXMfj/Lemonldap-NG-Cli-0.2-0/blib/arch
    /tmp/loop_over_bdir-1601045-niXMfj/Lemonldap-NG-Cli-0.2-0/blib/lib
    /home/sand/src/perl/repoperls/installed-perls/host/k93jammy/v5.37.10/5674/lib/site_perl/5.37.10/x86_64-linux-ld
    /home/sand/src/perl/repoperls/installed-perls/host/k93jammy/v5.37.10/5674/lib/site_perl/5.37.10
    /home/sand/src/perl/repoperls/installed-perls/host/k93jammy/v5.37.10/5674/lib/5.37.10/x86_64-linux-ld
    /home/sand/src/perl/repoperls/installed-perls/host/k93jammy/v5.37.10/5674/lib/5.37.10
    .

[jkeenan]

Patch submitted upstream today suppressing the 'given is deprecated' warnings and permitting tests to pass once again: doherty/App-perlhl#3. As the distribution's last CPAN release was in 2013, I would not consider this to be a release blocker to 5.38.0.

[haarg]

Silencing deprecated warnings is almost never an appropriate solution to these problems. It just means the dists fail again when smartmatch is removed.

[jkeenan]

Silencing deprecated warnings is almost never an appropriate solution to these problems. It just means the dists fail again when smartmatch is removed.

I agree with you -- but we're in a situation where we shouldn't make the perfect (rewriting the module to not use smartmatch) the enemy of the good.

Two days ago I examined all open tickets bearing the 'smartmatch' label. Of those, 13 had no indication on their upstream bug trackers that they were breaking against blead at CPANtesters. I began working my way through those tickets, but quickly learned that rewriting those distributions to not use given/when/default or smartmatch was non-trivial (especially given that I myself never used any of that syntax). So I created pull requests in two situations where I could make the code somewhat less bad, given that our target date for perl-5.38.0 is next week.

If there is some standard language we can post in upstream bug trackers about this pending deprecation, I would create tickets for those 11 or so distributions. And, of course, if there is someone who is familiar with smartmatch and friends who can provide patches for those distributions, that would be welcome.

[Grinnz]

I would suggest creating an issue here tracking distributions broken by this so their status can continue to be watched as smartmatch is moved towards removal, even if their BBC status is temporarily resolved.