BBC: Blead breaks PERLANCAR/Data-Sah-0.914.tar.gz under German locale

[andk]

Description

With v5.37.3-160-g818cdb7aa9 tests started to fail for PERLANCAR/Data-Sah-0.914.tar.gz under the locale de_DE.utf8. @perlancar , you may want to have a look!

Sample fail report: http://www.cpantesters.org/cpan/report/4299e636-7ac5-11ed-983f-0a782672d79c

Bisect leads me to:

commit 818cdb7aa9f85227c1c7313257c6204c872beb94 (HEAD)
Author: Karl Williamson <khw@cpan.org>
Date:   Sun Apr 11 05:57:07 2021 -0600

    locale.c: Skip code if will be a no-op

Steps to Reproduce

LC_NUMERIC=de_DE.utf8 LC_TIME=de_DE.utf8 LC_MONETARY=de_DE.utf8 LC_PAPER=de_DE.utf8 LC_NAME=de_DE.utf8 LC_ADDRESS=de_DE.utf8 LC_TELEPHONE=de_DE.utf8 LC_MEASUREMENT=de_DE.utf8 LC_IDENTIFICATION=de_DE.utf8 cpan -i PERLANCAR/Data-Sah-0.914.tar.gz

Expected behavior

Should build, test and install the pkg

Perl configuration

# perl -V output goes here
Summary of my perl5 (revision 5 version 37 subversion 4) configuration:
  Commit id: f2582f5b18658f945a763f2edc110cdc7c5220e7
  Platform:
    osname=linux
    osvers=5.19.0-1-amd64
    archname=x86_64-linux-thread-multi
    uname='linux k93msid 5.19.0-1-amd64 #1 smp preempt_dynamic debian 5.19.6-1 (2022-09-01) x86_64 gnulinux '
    config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.37.4/29fb -Dmyhostname=k93msid -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Duseithreads -Uuselongdouble -DEBUGGING=both'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='cc'
    ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
    optimize='-O2 -g'
    cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='12.2.0'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/x86_64-linux-gnu /usr/lib /usr/lib64
    libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=/lib/x86_64-linux-gnu/libc.so.6
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version='2.34'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'


Characteristics of this binary (from libperl): 
  Compile-time options:
    DEBUGGING
    HAS_TIMES
    MULTIPLICITY
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_HASH_FUNC_SIPHASH13
    PERL_HASH_USE_SBOX32
    PERL_MALLOC_WRAP
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    PERL_TRACK_MEMPOOL
    PERL_USE_DEVEL
    PERL_USE_SAFE_PUTENV
    USE_64_BIT_ALL
    USE_64_BIT_INT
    USE_ITHREADS
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_COLLATE
    USE_LOCALE_CTYPE
    USE_LOCALE_NUMERIC
    USE_LOCALE_TIME
    USE_PERLIO
    USE_PERL_ATOF
    USE_REENTRANT_API
    USE_THREAD_SAFE_LOCALE
  Built under linux
  Compiled at Sep 22 2022 08:44:31
  %ENV:
    PERL5LIB=""
    PERL5OPT=""
    PERL5_CPANPLUS_IS_RUNNING="3628348"
    PERL5_CPAN_IS_RUNNING="3628348"
    PERL_CANARY_STABILITY_NOPROMPT="1"
    PERL_MM_USE_DEFAULT="1"
    PERL_USE_UNSAFE_INC="1"
  @INC:
    /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.37.4/29fb/lib/site_perl/5.37.4/x86_64-linux-thread-multi
    /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.37.4/29fb/lib/site_perl/5.37.4
    /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.37.4/29fb/lib/5.37.4/x86_64-linux-thread-multi
    /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.37.4/29fb/lib/5.37.4
    .

[khwilliamson]

This is likely fixed in 5.37.7

[khwilliamson]

by cb777d7

[jkeenan]

I wanted to confirm that this problem has been fixed in v5.37.7. I had previously installed perl at that tag and installed Task::CPAN::Reporter against that perl. I then called:

LC_NUMERIC=de_DE.utf8 LC_TIME=de_DE.utf8 LC_MONETARY=de_DE.utf8 LC_PAPER=de_DE.utf8 LC_NAME=de_DE.utf8 LC_ADDRESS=de_DE.utf8 LC_TELEPHONE=de_DE.utf8 LC_MEASUREMENT=de_DE.utf8 LC_IDENTIFICATION=de_DE.utf8 ./bin/cpan Data::Sah

But the locale settings didn't take. My output included:

CPAN: CPAN::Reporter loaded ok (v1.2018)
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LC_ALL = (unset),
	LC_NAME = "de_DE.utf8",
	LC_MEASUREMENT = "de_DE.utf8",
	LC_TIME = "de_DE.utf8",
	LC_PAPER = "de_DE.utf8",
	LC_IDENTIFICATION = "de_DE.utf8",
	LC_NUMERIC = "de_DE.utf8",
	LC_MONETARY = "de_DE.utf8",
	LC_TELEPHONE = "de_DE.utf8",
	LC_ADDRESS = "de_DE.utf8",
	LANG = (unset)
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").

I then checked the available locales on my machine:

$ uname -mrs
FreeBSD 12.3-RELEASE-p1 amd64
$ locale -a | ack 'de_DE'
de_DE.ISO8859-1
de_DE.ISO8859-15
de_DE.UTF-8

I reformulated my invocation as follows:

LC_NUMERIC=de_DE.UTF-8 LC_TIME=de_DE.UTF-8 LC_MONETARY=de_DE.UTF-8 LC_PAPER=de_DE.UTF-8 LC_NAME=de_DE.UTF-8 LC_ADDRESS=de_DE.UTF-8 LC_TELEPHONE=de_DE.UTF-8 LC_MEASUREMENT=de_DE.UTF-8 LC_IDENTIFICATION=de_DE.UTF-8 ./bin/cpan Data::Sah

But while I avoided the fallback to the standard locale, I failed to install. The output ended with:

  PERLANCAR/Data-Sah-0.914.tar.gz
2 dependencies missing (Data::Sah::Coerce,Data::Sah::CoerceCommon); additionally test harness failed
  /usr/bin/make test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try:
  reports PERLANCAR/Data-Sah-0.914.tar.gz

I again reformulated the invocation to first install Data::Sah::Coerce and Data::Sah::CoerceCommon. No better results. My hunch is that this CPAN module has problems above and beyond BBC breakage and that we shouldn't spend any more time on it. I recommend closing the ticket.

[andk]

I tend to disagree. I've provided two reports with v5.37.7, one with C locale gives a PASS, one with German locale gives a FAIL. I concede that some dependency declarations seem to be missing, but this obstacle can be worked around. Once you have a PASS with C locale, all that is needed is another run with the German locale:

• the fail: http://www.cpantesters.org/cpan/report/76d9b0f0-82c4-11ed-b838-8a5594d1cf8c
• the pass: http://www.cpantesters.org/cpan/report/b1732e58-82c4-11ed-9b91-486194d1cf8c

Let me remind you that the bisect before the release of 5.37.7 was leading to a different commit than #20565:

• bisect for PERLANCAR/Data-Sah-0.914.tar.gz was leading to 818cdb7
• bisect for KARASIK/Prima-1.67.tar.gz was leading to 9f5a615

The latter is now fixed (report: http://www.cpantesters.org/cpan/report/f7a517c2-82ad-11ed-83bd-6a7c91d1cf8c)

Please let me know if I can help with further information.

[rjbs]

@khwilliamson What do you think about whether this is fixed (see Andreas's comment above).

[khwilliamson]

I installed and ran tests for Data::Sah and got

All tests successful.
Files=29, Tests=254,

It was painful doing this, because apparently the dependencies aren't fully specified, so I kept having to drill down to find and install new ones. I notice that in the fail report in this ticket for this module, it couldn't find Data::Dumper, which makes me wonder if something else was going wrong

[khwilliamson]

(using blead)