Perl_debop and Perl_runops_debug and PL_runops_dbg, are they DEBUGGING or not?

[p5pRT]

Migrated from rt.perl.org#123491 (status was 'new')

Searchable as RT123491$

[p5pRT]

From @bulk88

While writing
https://rt.perl.org/Ticket/Display.html?id=123473#txn-1323850 . I
discovered that even though Perl_debop is not exported on Win32 Perl
unless DEBUGGING Win32 perl because of
http://perl5.git.perl.org/perl.git/blame/09c759bcfa4c2880c571df4da20458b2f781debf:/makedef.pl#l248
Perl_debop is still exists in perl521.dll on non-DEBUGGING Win32 Perl.
Perl_debop is used by 1 CPAN module at
https://github.com/rurban/B-Stats/blob/master/Stats.xs#L71 although it
isn't critical to the purpose of that module and Perl_debop is ifdef-ed
away on Win32 in that Module.

I determined the dependency chain is

->Perl_runops_debug->Perl_debop
->PL_runops_dbg->Perl_runops_debug->Perl_debop

Perl_runops_debug the C function shows no CPAN users and 1 core user

http://grep.cpan.me/?q=runops_debug[^|]

4bba85d:/ext/Devel-Peek/Peek.xs#l10

PL_runops_dbg has CPAN 1 user

https://metacpan.org/source/VPIT/Scope-Upper-0.25/Upper.xs#L1875

and no core users but there is a comment in core

/* dummy variables that hold pointers to both runops functions, thus forcing
* them *both* to get linked in (useful for Peek.xs, debugging etc) */

EXTCONST runops_proc_t PL_runops_std
INIT(Perl_runops_standard);
EXTCONST runops_proc_t PL_runops_dbg
INIT(Perl_runops_debug);

but Peek.xs uses the Perl_runops_debug symbol, which is a function ptr,
not the symbol PL_runops_dbg which is a pointer to a function ptr (AKA
DATA).

static bool
_runops_debug(int flag)
{
dTHX;
const bool d = PL_runops == Perl_runops_debug;

if (flag >= 0)
PL_runops = flag ? Perl_runops_debug : Perl_runops_standard;
return d;
}

af2f0da
4b8f2e6
60e4ec2

So I am thinking either PL_runops_std and PL_runops_dbg are removed, or
Perl_runops_debug and Perl_runops_standard are removed.

Also if Perl_debop will remain in non-DEBUGGING it should be exported by
removing the if(DEBUGGING) from makedef.pl.

"Remain in non-DEBUGGING" means Perl_runops_debug won't be inside #ifdef
DEBUGGING since on non-DEBUGGING Perl_debop is only referenced by
Perl_runops_debug and not by export table ATM and if Perl_runops_debug
is removed on non-DEBUGGING Perl_debop disappears with it.

There is also what seems to be a dead define called SKIP_DEBUGGING and I
can't find anything that sets it, or set it in the past, maybe it should
be removed?

http://markmail.org/message/3cvoyl6podvl7ol7
1045810

Perl Info

Flags:
                   category=core
                   severity=low

Site configuration information for perl 5.21.7:

Configured by Owner at Sat Nov 22 21:54:54 2014.

Summary of my perl5 (revision 5 version 21 subversion 7) configuration:
                 Local Commit: 1bce52df028aabe28c20b2d97949e35c17ea811e
                 Ancestor: 7072da8afeba4c87ae623cd913e274396ffcf1cd
                 Platform:
                   osname=MSWin32, osvers=5.1,
archname=MSWin32-x86-multi-thread
                   uname=''
                   config_args='undef'
                   hint=recommended, useposix=true, d_sigaction=undef
                   useithreads=define, usemultiplicity=define
                   use64bitint=undef, use64bitall=undef, uselongdouble=undef
                   usemymalloc=n, bincompat5005=undef
                 Compiler:
                   cc='cl', ccflags ='-nologo -GF -W3 -O1 -MD -Zi -DNDEBUG
-G7 -GL
-DWIN32 -D_CONSOLE -DNO_STRICT  -DPERL_TEXTMODE_SCRIPTS
-DPERL_HASH_FUNC_ONE_AT_A_TIME -DNO_MATHOMS -DPERL_IMPLICIT_CONTEXT
-DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T',
                   optimize='-O1 -MD -Zi -DNDEBUG -G7 -GL',
                   cppflags='-DWIN32'
                   ccversion='13.10.6030', gccversion='', gccosandvers=''
                   intsize=4, longsize=4, ptrsize=4, doublesize=8,
byteorder=1234,
doublekind=3
                   d_longlong=undef, longlongsize=8, d_longdbl=define,
longdblsize=8,
longdblkind=0
                   ivtype='long', ivsize=4, nvtype='double', nvsize=8,
Off_t='__int64',
lseeksize=8
                   alignbytes=8, prototype=define
                 Linker and Libraries:
                   ld='link', ldflags ='-nologo -nodefaultlib -debug
-opt:ref,icf
-ltcg  -libpath:"c:\perl521\lib\CORE"  -machine:x86'
                   libpth="C:\Program Files\Microsoft Visual Studio .NET
2003\VC7\lib"
                   libs=oldnames.lib kernel32.lib user32.lib gdi32.lib
winspool.lib
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib
odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
                   perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib
winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib
oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib
version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
                   libc=msvcrt.lib, so=dll, useshrplib=true,
libperl=perl521.lib
                   gnulibc_version=''
                 Dynamic Linking:
                   dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef,
ccdlflags=' '
                   cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib
-debug
-opt:ref,icf -ltcg  -libpath:"c:\perl521\lib\CORE"  -machine:x86'

Locally applied patches:
                   ce7a4d57d0acca9f39a84d36d708c4505dfe45ca
                   ca0b263f4b167ddf97416f657d79ab5bd3344357
                   08919bf863666074243240abbd19cd1a74cc7b74
                   b8a043377dbf39548709b107a11e5cc2714c0e9a
                   efa855eb5cffb7739616c295dd968d1510efeeb0
                   1d47d0b810e26d9a2f9101fb813bd5b3dd332cc9
                   3faca062ddb056db54f73fa55b0a9d473675dd33
                   0b3e905bda3e75ad948a1213f620656b60807393
                   1b1efc719fde05d215e5a13fb38c03e12a3aab08
                   1bce52df028aabe28c20b2d97949e35c17ea811e


@INC for perl 5.21.7:
                   ..\lib
                   C:/perl521/srcnewb4opt/lib
                   .


Environment for perl 5.21.7:
                   HOME (unset)
                   LANG (unset)
                   LANGUAGE (unset)
                   LD_LIBRARY_PATH (unset)
                   LOGDIR (unset)
                   PATH=C:\WINDOWS\system32;C:\Program Files\Microsoft 
Visual
Studio
.NET 2003\Vc7\bin;C:\Program Files\Microsoft Visual Studio .NET
2003\Common7\IDE;C:\WINDOWS;C:\Program Files\Git\cmd;C:\Program
Files\Microsoft Visual Studio .NET 2003\Common7\Tools\bin;C:\perl\bin
                   PERL_BADLANG (unset)
                   PERL_JSON_BACKEND=Cpanel::JSON::XS
                   PERL_YAML_BACKEND=YAML
                   SHELL (unset)