pp_formline uses sv_pos_b2u/sv_pos_u2b

[p5pRT]

Migrated from rt.perl.org#72780 (status was 'open')

Searchable as RT72780$

[p5pRT]

From @nwc10

pp_ctl.c
602​: sv_pos_u2b(sv, &itembytes, 0);
616​: sv_pos_b2u(sv, &itemsize);
659​: sv_pos_u2b(sv, &itembytes, 0);
677​: sv_pos_b2u(sv, &itemsize);
877​: /* Mustn't call sv_pos_b2u() as it does a second
882​: sv_pos_b2u(sv, &itemsize);

All in pp_formline.

This means that formats will not work correctly with UTF-8 strings over 2GB.

Nicholas Clark

[p5pRT]

From @nwc10

pp_ctl.c
602​: sv_pos_u2b(sv, &itembytes, 0);
616​: sv_pos_b2u(sv, &itemsize);
659​: sv_pos_u2b(sv, &itembytes, 0);
677​: sv_pos_b2u(sv, &itemsize);
877​: /* Mustn't call sv_pos_b2u() as it does a second
882​: sv_pos_b2u(sv, &itemsize);

All in pp_formline.

This means that formats will not work correctly with UTF-8 strings over 2GB.

Nicholas Clark

[p5pRT]

From zefram@fysh.org

Nicholas Clark wrote​:

This means that formats will not work correctly with UTF-8 strings over 2GB.

There are going to be an awful lot of standing bugs of this nature.
I think these should be tackled systematically in 5.13. Not piecemeal,
and not in a rush for 5.12.

-zefram

[p5pRT]

The RT System itself - Status changed from 'new' to 'open'

[p5pRT]

From @nwc10

On Sat, Feb 13, 2010 at 08​:12​:14PM +0000, Zefram wrote​:

Nicholas Clark wrote​:

This means that formats will not work correctly with UTF-8 strings over 2GB.

There are going to be an awful lot of standing bugs of this nature.
I think these should be tackled systematically in 5.13. Not piecemeal,
and not in a rush for 5.12.

Oh, I quite agree. I was reviewing all uses of sv_pos_b2u/sv_pos_u2b,
effectively triaging them w.r.t. 5.12.0. I don't see any of these other bugs
as "things we should fix before 5.12.0". However, I'm hopeful that most of
the fixes will be low risk and binary compatible, hence the option is there
to merge them to 5.12.1, should the maint pumpking so wish.

Nicholas Clark

[p5pRT]

From @cpansprout

Exact copy of 72780.

[p5pRT]

@cpansprout - Status changed from 'new' to 'resolved'